[Kmymoney-devel] Review Request 115302: Fix loosing track of check number if check number sequence is interrupted.

Allan Anderson agander93 at gmail.com
Mon Jan 27 11:31:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115302/
-----------------------------------------------------------

(Updated Jan. 27, 2014, 11:31 a.m.)


Review request for KMymoney.


Changes
-------

Follow-up patch to fix handling of number field.
There was no check that a new 'next number' did not already exist.  For instance, if there is the sequence 22,23,24, and the user entered a new transaction numbered 21, the 'next number' would have been 22, which already exists.
Deletion of a numered transaction would produce an incorrect next number.
An edit of an existing number was not saved.
These issues, which exist also in the stable release, have been fixed,


Bugs: 319801
    http://bugs.kde.org/show_bug.cgi?id=319801


Repository: kmymoney


Description
-------

If a user's sequence of check numbers is broken by, say 'ATM' or an invoice number such as 'No 123-001 ABC', the next check number produced will be '1', entries containing alpha or punctuation characters not being saved.
The fix corrects this by saving the complete entry, and uses any entered numeric part to calculate the next number in sequence.  If an existing numeric entry is edited, this entry will be taken into account for the next number.

There are some quirks.  If the entry which led to the current 'next number' is deleted, it is not possible to revert to the previous, now forgotten, 'next number', so the produced 'next number' is likely to leave a 'gap', and may need editing.  Also, there is no check that a new 'next number' does not already exist.  For instance, if there is the erroneous sequence 23,23,24, the 'next number' will be the expected 25.  However, if the user corrects the error by changing a 23 to 22, the new 'next number' will be 23, which also already exists.  These issues, which exist also in the current release, also have been fixed, but are not included in this Review, for clarity.  They will be submitted separately later.

The values in the unit test which are not purely numeric can now be used, and produce correct 'next numbers'.


Diffs (updated)
-----

  kmymoney/kmymoneyutils.cpp e89528e 
  kmymoney/kmymoneyutils.h a899121 
  kmymoney/kmymoney.cpp 7a2fd4f 
  kmymoney/dialogs/transactioneditor.cpp 3c148d8 
  kmymoney/dialogs/transactioneditor.h db86832 

Diff: https://git.reviewboard.kde.org/r/115302/diff/


Testing
-------

Numerous manual test cases run.  Unit tests run.


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140127/092eeebb/attachment.html>


More information about the KMyMoney-devel mailing list