[Kmymoney-devel] Review Request 115302: Fix loosing track of check number if check number sequence is interrupted.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115302/#review48285
-----------------------------------------------------------

Ship it!


Looks good to me

- Thomas Baumgart


On Jan. 24, 2014, 7:24 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115302/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 7:24 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 319801
>     http://bugs.kde.org/show_bug.cgi?id=319801
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> If a user's sequence of check numbers is broken by, say 'ATM' or an invoice number such as 'No 123-001 ABC', the next check number produced will be '1', entries containing alpha or punctuation characters not being saved.
> The fix corrects this by saving the complete entry, and uses any entered numeric part to calculate the next number in sequence.  If an existing numeric entry is edited, this entry will be taken into account for the next number.
> 
> There are some quirks.  If the entry which led to the current 'next number' is deleted, it is not possible to revert to the previous, now forgotten, 'next number', so the produced 'next number' is likely to leave a 'gap', and may need editing.  Also, there is no check that a new 'next number' does not already exist.  For instance, if there is the erroneous sequence 23,23,24, the 'next number' will be the expected 25.  However, if the user corrects the error by changing a 23 to 22, the new 'next number' will be 23, which also already exists.  These issues, which exist also in the current release, also have been fixed, but are not included in this Review, for clarity.  They will be submitted separately later.
> 
> The values in the unit test which are not purely numeric can now be used, and produce correct 'next numbers'.
> 
> 
> Diffs
> -----
> 
>   kmymoney/kmymoneyutils.cpp 7058557 
>   kmymoney/kmymoneyutils.h f64a55e 
>   kmymoney/dialogs/transactioneditor.cpp 26e7672 
>   kmymoney/dialogs/transactioneditor.h 25705a0 
> 
> Diff: https://git.reviewboard.kde.org/r/115302/diff/
> 
> 
> Testing
> -------
> 
> Numerous manual test cases run.  Unit tests run.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140126/fe873dca/attachment.html>