[Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113427/#review46543
-----------------------------------------------------------


Looks good to me to be shipped once my two remarks have been fixed.


kmymoney/dialogs/investtransactioneditor.cpp
<https://git.reviewboard.kde.org/r/113427/#comment33232>

    Isn't that simply
    
    if(memo) {
      d->m_activity->m_memoChanged = (memo->toPlainText() != d->m_activity->m_memoText);
    }



kmymoney/dialogs/transactioneditor.cpp
<https://git.reviewboard.kde.org/r/113427/#comment33233>

    You should also check for memo being a NULL ptr here just like in InvestTransactionEditor::slotUpdateInvestMemoState(void)


- Thomas Baumgart


On Oct. 25, 2013, 1:06 a.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113427/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 1:06 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 289351
>     http://bugs.kde.org/show_bug.cgi?id=289351
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> There was a previous fix for this problem - Git commit 9485826cfb50816d2df4dac9709b4beb255b8b75 by Cristian One?. Unfortunately, this was inadvertently disabled when BUG:311481 REVIEW:107714 was committed.  This is now fixed.
> This review adds the same capability for investment transactions.
> In addition, there have been requests that when clearing the memo field, it should when required be empty rather that containing a blank character.  It is necessary to enter a character in the memo field in order to signal that an edit has occurred, but now that character may then be deleted to leave the field empty, if that is what is required.
> With investment transactions, it is always necessary to enter the security name as well. This requirement could probably be removed, but it is probably sensible to be editing just a single security.
> As with all editing of multiple items, all fields appear as blank initially. This has been retained here with multiple memo editing, but if desired, this could be changed and the field could be left showing previous content, which could be more intuitive for a user wanting to have an empty field.
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/investactivities.h aa4800f 
>   kmymoney/dialogs/investactivities.cpp e4760e5 
>   kmymoney/dialogs/investtransactioneditor.h 20e3819 
>   kmymoney/dialogs/investtransactioneditor.cpp 805bd8d 
>   kmymoney/dialogs/transactioneditor.h f07dafb 
>   kmymoney/dialogs/transactioneditor.cpp 71d94ec 
> 
> Diff: https://git.reviewboard.kde.org/r/113427/diff/
> 
> 
> Testing
> -------
> 
> Numerous groups of investment and checking transactions entered and edited correctly.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140101/40cb9c34/attachment.html>