[Kmymoney-devel] Review Request 115338: Fix loosing track of check number if check number sequence is interrupted.

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115338/
-----------------------------------------------------------

(Updated Feb. 17, 2014, 1:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Bugs: 319801
    http://bugs.kde.org/show_bug.cgi?id=319801


Repository: kmymoney


Description
-------

Follow-up patch on https://git.reviewboard.kde.org/r/115302/,
 to fix handling of number field.
There was no check that a new 'next number' did not already exist.  For instance, if there is the sequence 22,23,24, and the user entered a new transaction numbered 21, the 'next number' would have been 22, which already exists.
Deletion of a numered transaction would produce an incorrect next number.
An edit of an existing number was not saved.
These issues, which exist also in the stable release, have been fixed.
(new Reviewboard item raised for this part, on suggestion of Thomas Baumgart).


Diffs
-----

  kmymoney/kmymoneyutils.cpp e89528e 
  kmymoney/kmymoneyutils.h a899121 
  kmymoney/kmymoney.cpp 7a2fd4f 
  kmymoney/dialogs/transactioneditor.cpp 3c148d8 
  kmymoney/dialogs/transactioneditor.h db86832 

Diff: https://git.reviewboard.kde.org/r/115338/diff/


Testing
-------

Numerous manual test cases run.  Unit tests run.


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140217/8dc810fa/attachment.html>