[Kmymoney-devel] Review Request 110212: Add Merge Payee Option

[Felipe Tonello]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110212/
-----------------------------------------------------------

(Updated Feb. 15, 2014, 1:23 a.m.)


Status
------

This change has been discarded.


Review request for KMymoney.


Repository: kmymoney


Description
-------

Patch 1: Implements the actual merge operation.

Patches 2 and 3: Implements KAction and context menu option[2] and a button in
payees view[3].

Patch 4: This patch might be controversial because I believe the functionality
provided by this patch was not implemented because of some reason that it's
not documented.

TODO: improve user experience (UX) by:
  - Use a dialog similar to the KPayeeReassignDlg. Probably just making it more generic.
  - Improve slotPayeeNew() to not to ask if user wants to create new payee or not.

FIXME: Too much duplicated code from slotPayeeDelete() and others. The way that the
       MyMoney* Objects are designed requires too much repeated work, so I believe using
       generic helper functions might be a good idea.


Diffs
-----

  kmymoney/kmymoney.h 22515f4e842a48645ea82ee50d3bd735927b87d5 
  kmymoney/kmymoney.cpp 063f8b5a0357e39de2482a93abbd4cb33f869e19 
  kmymoney/kmymoneyui.rc f35364158b77af1ee066d779b59ded7578f5c8f2 
  kmymoney/views/kpayeesview.h 1fb9633f96355e0cd0da231afc8384bc48f01ca6 
  kmymoney/views/kpayeesview.cpp 97a3f93ab034707db30fb3085c79b06e7ca8f1ca 
  kmymoney/views/kpayeesviewdecl.ui 8d9c0083780c5cfb31dc3a237aa1deac1c708cca 

Diff: https://git.reviewboard.kde.org/r/110212/diff/


Testing
-------


Thanks,

Felipe Tonello

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140215/1654ac3e/attachment.html>