[Kmymoney-devel] Review Request 115551: Performance optimization for MyMoneySeqAccessMgr::calculateBalance().

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115551/#review49256
-----------------------------------------------------------

Ship it!


I don't see it either (anymore). There was a reason once, but it might have been optimized away in the meantime w/o adjusting the balance collector. Go ahead and check it in.

- Thomas Baumgart


On Feb. 8, 2014, 1:53 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115551/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 1:53 p.m.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Performance optimization for MyMoneySeqAccessMgr::calculateBalance().
> 
> It's still the most expensive method of MyMoneySeqAccessMgr but it's
> faster now.
> 
> I don't really see why the balance of multiple accounts was computed
> just the return the balance of the requested account while throwing
> away the rest of the data.
> 
> Thomas, I need you opinion on this. 
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp ccf2d5873c6cd0ff039c317cd15d237b82426d2d 
> 
> Diff: https://git.reviewboard.kde.org/r/115551/diff/
> 
> 
> Testing
> -------
> 
> Ran unit-tests and checked account balances againts the previous version.
> 
> 
> File Attachments
> ----------------
> 
> KCachegrind data before optimization
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/08/12e5e81e-1230-48a3-bb42-1217f022a839__before.png
> KCachegrind data after optimization
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/08/240fb67f-266c-41a0-ba85-534d85a0b7f3__after.png
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140208/8bea2e40/attachment.html>