[Kmymoney-devel] Review Request 119911: Updated extraction code to support "Financial Times UK Funds" source for online price quotes

[David Houlden]

Hi all,

It was me that sent this change to Thomas. I just checked and I have subsequently 
made another change to the URL. My version now has GBX instead of GBP. If you can 
give me a while I will check Thomas's patch to verify it works for me as I am using that 
source for prices. Bit busy just now but will get back to you later.

David.

On Saturday 23 August 2014 10:52:36 Cristian Oneț wrote:



This is an automatically generated e-mail. To reply, visit: 
https://git.reviewboard.kde.org/r/119911/[1] 


On August 23rd, 2014, 10:43 a.m. UTC, *Cristian Oneț* wrote: 
Ship It! 
On August 23rd, 2014, 10:44 a.m. UTC, *Cristian Oneț* wrote: 
Although the currency symbol could be made configurable in the URL. For fund in euro, 
like http://funds.ft.com/uk/Tearsheet/Summary?s=ES0102562032:EUR 
On August 23rd, 2014, 10:49 a.m. UTC, *Thomas Baumgart* wrote: 
Right, but we only have the symbol of the security. This is something the user must 
take care of, since we don't know which currency to use at this point. Also, this is a 
completely different URL. 
OK, then ship it :).


- Cristian 


On August 23rd, 2014, 10:40 a.m. UTC, Thomas Baumgart wrote: 
Review request for KMymoney.
By Thomas Baumgart. 
/Updated Aug. 23, 2014, 10:40 a.m./ 
*Repository: *kmymoney 
*Description *
This patch shall support "Financial Times UK Funds" as source for online price quotes 
again. Apparently their format changed. I received this patch a long time ago via e-mail 
and just found it sitting in my stash. Before I add it to master, I wanted someone to 
review it. 

*Testing *
Compile, Link, Run the application but no testing towards the new source 

*Diffs *
     *  kmymoney/converter/webpricequote.cpp (7b1d24d) 
View Diff[2] 




--------
[1] https://git.reviewboard.kde.org/r/119911/
[2] https://git.reviewboard.kde.org/r/119911/diff/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140823/ae1192f2/attachment-0001.html>