[Kmymoney-devel] Review Request 119911: Updated extraction code to support "Financial Times UK Funds" source for online price quotes

[Thomas Baumgart]

> On Aug. 23, 2014, 12:43 p.m., Cristian Oneț wrote:
> > Ship It!
> 
> Cristian Oneț wrote:
>     Although the currency symbol could be made configurable in the URL. For fund in euro, like http://funds.ft.com/uk/Tearsheet/Summary?s=ES0102562032:EUR

Right, but we only have the symbol of the security. This is something the user must take care of, since we don't know which currency to use at this point. Also, this is a completely different URL.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119911/#review65087
-----------------------------------------------------------


On Aug. 23, 2014, 12:40 p.m., Thomas Baumgart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119911/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2014, 12:40 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> This patch shall support "Financial Times UK Funds" as source for online price quotes again. Apparently their format changed. I received this patch a long time ago via e-mail and just found it sitting in my stash. Before I add it to master, I wanted someone to review it.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/webpricequote.cpp 7b1d24d 
> 
> Diff: https://git.reviewboard.kde.org/r/119911/diff/
> 
> 
> Testing
> -------
> 
> Compile, Link, Run the application but no testing towards the new source
> 
> 
> Thanks,
> 
> Thomas Baumgart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140823/5a52f169/attachment.html>