[Kmymoney-devel] csvimport crash on multiple import

[Allan]

Hi Alvaro
On 25/04/14 12:46, Alvaro Soliverez wrote:>
>Hi Allan,
>
> I haven't really tried it, so it's just an outside view, and you can
> ignore my comments.

No, I welcome all feedback, otherwise it's "This is the way I wrote it, 
and I know what I really meant." as the OP found out.

> Don't broaden the options that much, or at the very least, make the
> most common use case the easier to follow, and stow away the options
> for more uncommon usecases. Also, in this case finish is not "import
> the file" which is already done, but "save settings for next time".
> That should be clarified to the user.

Just to expand this use, there are several pages of user parameter 
input, which may be saved for next time, for that particular profile. 
So, next time, a click On the 'Skip Setup' box will use the saved 
parameters and go straight to the KMM Account Selection screen.  Again, 
assuming Skip Setup, the user lands back on the Intro page, where the 
Select File button is now labeled 'Next File', plus the 'Cancel' becomes 
'Finish'.  I'll add a tooltip to show 'Save settings and exit'.

Without the 'Skip', on the last page there is the 'Import button', but 
also 'Make QIF file', 'Back' in case a parameter change is needed, 
'Finish', and 'Cancel', although the QIF button is not enabled until the 
Import is done.  I think it would be better if also the 'Finish' is 
button is not enabled until the Import is done.  I hope that helps you, 
and everyone.

> Regarding disable the main app, I agree it would be nice to have it
> enabled if you can use it to check the import. That looks really
> useful to me.

Yes, me too.  I'll revert that change.
>
> Regards,
> Alvaro

Allan

> On Fri, Apr 25, 2014 at 7:35 AM, Allan <agander93 at gmail.com> wrote:
>> On 24/04/14 02:18, Chris wrote:
>>>
>>>
>>> Ok. You got me!
>>>
>>> Will need to remove the "select file" button from the intermediate pages.
>>>
>>
>> There weren't any intermediate pages, but it is now sorted.  On completion
>> of each import, control returns to the into page, allowing access to the
>> Skip Setup button, if needed, and Next File and Finish buttons.
>>
>>
>>> When stepping through the settings, the last pages buttons are a bit
>>> confusing you are presented with a finish button and import csv button.
>>> I think you should have one or the other not both. A couple of times I
>>> have automatically clicked finish expecting it to import the selected
>>> file.
>>
>>
>> The reason I have them both is that if, after doing an import, the user
>> might realise/get told that a parameter is incorrect.  So, he can backtrack
>> a bit, correct the error, then import again without having to exit or
>> backtrack right to the intro page.  Or, he/she might just have imported into
>> the wrong account and wants to try again.  Alternatively, he may Finish,
>> which saves his settings, or cancel, which doesn't.
>>
>> Cristian made a change that I don't like, in that now, the main KMM app is
>> disabled until the plugin is closed.  I prefer the original, which leaves
>> the plugin still available, while allowing the user to check the import
>> result/whatever, without having to close and reopen the plugin and navigate
>> through again.
>>
>>
>>> I also have noted clicking on the cancel button brings up a dialogue
>>> that looks like it wants to shutdown kmymoney rather than just close the
>>> wizard. I don't think you need a warning to close the wizard and it is
>>> confusing. No data is lost when closing it, so pressing the cancel
>>> button should simply close the wizard.
>>
>>
>> I did already think about clarifying the message, but as you say, it can go
>> without any problem.
>>
>>> Chris
>>
>>
>> Allan
>> _______________________________________________
>> KMyMoney-devel mailing list
>> KMyMoney-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>