[Kmymoney-devel] Review Request 112847: Display equity accounts when enabled in payees page and unknown payee import dialog

[Alvaro Soliverez]

> On Sept. 21, 2013, 10:29 a.m., Cristian Oneț wrote:
> > I would wait for Thomas's opinion about this. Strictly from a programmer POV the patch looks fine, I'm not certain about the functionality, I don't know why the equity accounts were not available in the ledger until now.
> 
> Alvaro Soliverez wrote:
>     Equity accounts in KMM are hidden because it's advanced functionality and we try to hide the double-entry accounting as much as possible. Keep in mind that the equity accounts are not assets, or shares in a company, rather the net worth from opening balances in accounts.
>     
>     They are hidden in normal mode, and should be hidden.
> 
> Cristian Oneț wrote:
>     The current patch will only show the equity accounts in those places in expert mode.
>     
>     I don't see why the application should limit the kind of accounts unless there is some constraint related with the type of the equity account. If the equity accounts are normal accounts I don't see anything wrong in showing them in expert mode.

Because equity accounts are not normal accounts. Normally, you shouldn't need to enter transactions into these accounts. That's how it was for 10+ years. Then the accounts were enabled for manual transactions.

I fail to see a use case where you would need to have these accounts set for automatic import. I feel these equity accounts are being mistaken by stock accounts (which these are not)


- Alvaro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112847/#review40398
-----------------------------------------------------------


On Sept. 21, 2013, 12:41 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112847/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2013, 12:41 p.m.)
> 
> 
> Review request for KMymoney and Cristian Oneț.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> When enabled display of equity accounts with 'settings->general->filter->show equity accounts' equity accounts are not displayed in the "Default Account" tab of payee page and in the unknown payee import dialog. 
> 
> The related bug could be triggered with: 
> 1. create a new file
> 2. select the german skr03 standard chart of accounts. 
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.cpp 5619cc2 
>   kmymoney/views/kgloballedgerview.cpp 2057b47 
>   kmymoney/views/kpayeesview.cpp 69697e6 
> 
> Diff: http://git.reviewboard.kde.org/r/112847/diff/
> 
> 
> Testing
> -------
> 
> git master
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130930/c7b196a8/attachment.html>