[Kmymoney-devel] [kmymoney4] [Bug 312816] Resize ledger No. column & @ Dave

[aga]

Hi Cristian (and interested others, please)

On Tue, 24 Sep 2013 10:05:26 +0300
Cristian Oneț <onet.cristian at gmail.com> wrote:

> 2013/9/23 aga <agander93 at gmail.com>:
> [...]
> > If I open an existing reinvestdividend, which has an interest
> > category already entered, the interest amount box should open and
> > display the current amount.  The amount box does not show.  This is
> > both without and with your patches.
> >
> > Resizing the window enables the amount widget to show, but I haven't
> > yet found where it gets changed.

I have this working correctly, now, however....

> This is caused by the special handling of the reinvest action in
> InvestTransactionEditor::slotUpdateInterestVisibility which is
> incorrect. I guess even with a reinvest action the interest
> category-amount pair should work the same way like the fee
> category-amount pair (show the amount if the category is not empty).

I've brought the reinvest handling in investactivities.cpp, into line
with the fee handling. There was some redundant code there, where the
functionality was already handled in
InvestTransactionEditor::slotUpdateInterestVisibility().

> The code I just mentioned states that it tries do do one thing ("don't
> ever hide the label") but it breaks this behavior.

I don't think that's the case really.  I interpret it as distinguishing
between hiding a label and setting it to an empty string, which is what
is done.  However, I've just hidden the interest amount label and
there's no apparent adverse effect.

However, and I hope Dave Houlden and others may comment, I'm not sure
about the amount actually being displayed here.  In a reinvest dividend
transaction, the dividend is used to purchase further shares/units.  At
the moment, when a category has been entered for the transaction, the
Amount edit box also opens, which I think is confusing as it seems like
an invitation to the user to enter an amount, when there should be no
such amount, as the dividend has been used for the purchase.

What do others think?

Allan

> Regards,
> Cristian