[Kmymoney-devel] Review Request 112847: Display equity accounts when enabled in payees page and unknown payee import dialog

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112847/#review40398
-----------------------------------------------------------


I would wait for Thomas's opinion about this. Strictly from a programmer POV the patch looks fine, I'm not certain about the functionality, I don't know why the equity accounts were not available in the ledger until now.

- Cristian Oneț


On Sept. 20, 2013, 9:20 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112847/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2013, 9:20 p.m.)
> 
> 
> Review request for KMymoney and Cristian Oneț.
> 
> 
> Description
> -------
> 
> When enabled display of equity accounts with 'settings->general->filter->show equity accounts' equity accounts are not displayed in the "Default Account" tab of payee page and in the unknown payee import dialog. 
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.cpp 5619cc2 
>   kmymoney/views/kgloballedgerview.cpp 2057b47 
>   kmymoney/views/kpayeesview.cpp 69697e6 
> 
> Diff: http://git.reviewboard.kde.org/r/112847/diff/
> 
> 
> Testing
> -------
> 
> git master
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130921/facad511/attachment.html>