[Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112364/
-----------------------------------------------------------

(Updated Sept. 15, 2013, 4:26 p.m.)


Review request for KMymoney.


Changes
-------

As agreed below, this is to concentrate on the column width issues.
It is almost exclusively in the Register class, with revised versions of Register::adjustColumn(int col) and Register::resize(int col, bool force), which are much the same as in the original submission.
This will ensure each column is wide enough for its data, so no need (or ability) for the user to resize any individual columns.  Also, at the moment, while entering or editing a transaction, the width of all the edit edit boxes is considerably hidden by calculator or date entry buttons.  This is improved, and the Number column width can expand while editing, so the user can actually see all of his entry, instead of it scrolling out of sight.
The whole window may be resized, as now, but I'm abandoning, for now, the long-standing issue of investment edit widgets appearing/disappearing illogically.
The overall size of the patch is much reduced.  It is a replacement for the original one.


Description
-------

If I choose to use a complex system for check numbers, such that the whole number is not visible,
the only way I have available is to stretch the whole window. However, even that doesn't help,
as the whole of the increase is grabbed by the Details column.  I accept that it is likely that that
column is going to need to be the widest.  Then, why are the Payment and Deposit columns twice the
width of the Balance column, when that column may be likely to have the greatest value?  Ditto for
the Date.

This fix allows modification of column widths, but also resizes the individual columns to more suitable widths.

I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that.

I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide()
methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered
more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved
the issue, although with some complication.


This addresses bugs 312816 and 322768.
    http://bugs.kde.org/show_bug.cgi?id=312816
    http://bugs.kde.org/show_bug.cgi?id=322768


Diffs (updated)
-----

  kmymoney/dialogs/transactioneditor.h f07dafb 
  kmymoney/dialogs/transactioneditor.cpp 39049cf 
  kmymoney/views/kgloballedgerview.cpp 2057b47 
  kmymoney/widgets/register.h eebe78d 
  kmymoney/widgets/register.cpp 1bdf5bd 

Diff: http://git.reviewboard.kde.org/r/112364/diff/


Testing
-------

Extensive editing of sample files, and changing back and forth between different activity types, which tended to show
problem areas. atype run.


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130915/a4fb1176/attachment.html>