[Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.

Tue Sep 10 09:57:47 UTC 2013

> On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote:
> > kmymoney/dialogs/investactivities.cpp, line 198
> > <http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line198>
> >
> >     Could you add a little comment on why do you need to set the rowHeight later to this value?

>From the last paragraph of the description above -
I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide()
methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered
more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved
the issue, although with some complication.

> On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote:
> > kmymoney/dialogs/investactivities.cpp, line 204
> > <http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line204>
> >
> >     Also I don't see a reason why the timeouts passed to QTimer::signleShot vary that much, 5, 100, 150, is there a reason for it?

I can't give an explanation for why the should differ.  Having previously encountered this same problem some why ago, Thomas advised using the timer.  As before, I started off using a small value, but found that this didn't work in the new near-identical code area. So, I started to increase the delay.  In come cases, I had to use a large delay in order to see that the widget did finally respond.  I then started to reduce the value until failure, and then back-off.  Having got a particular widget finally responding, after further work I found that the problem was still sometimes there and had to make further adjustments.  In many cases, this 'tuning' was revisited.
When finally all appeared OK, I then found that during actual window resizing, some widgets would flicker quite badly during their repositioning, depending upon the speed of mouse movement.  The only way I could resolve that was by zeroing the widget height instead of hiding it.

On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote:
> > Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way.

The two came along together.  I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical.  So, for these, there is no patch fixing something, as there was no code there before.
Anyway, I'll see if I can do some separation.

- Allan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112364/#review39691
-----------------------------------------------------------

On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112364/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 5:12 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> If I choose to use a complex system for check numbers, such that the whole number is not visible,
> the only way I have available is to stretch the whole window. However, even that doesn't help,
> as the whole of the increase is grabbed by the Details column.  I accept that it is likely that that
> column is going to need to be the widest.  Then, why are the Payment and Deposit columns twice the
> width of the Balance column, when that column may be likely to have the greatest value?  Ditto for
> the Date.
> 
> This fix allows modification of column widths, but also resizes the individual columns to more suitable widths.
> 
> I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that.
> 
> I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide()
> methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered
> more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved
> the issue, although with some complication.
> 
> 
> This addresses bugs 312816 and 322768.
>     http://bugs.kde.org/show_bug.cgi?id=312816
>     http://bugs.kde.org/show_bug.cgi?id=322768
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/investactivities.cpp 50f33ed 
>   kmymoney/dialogs/investtransactioneditor.h 3e62c2a 
>   kmymoney/dialogs/investtransactioneditor.cpp e9f87fb 
>   kmymoney/dialogs/transactioneditor.h f07dafb 
>   kmymoney/dialogs/transactioneditor.cpp 39049cf 
>   kmymoney/views/kgloballedgerview.h 04a6303 
>   kmymoney/views/kgloballedgerview.cpp 78d98b2 
>   kmymoney/widgets/register.h eebe78d 
>   kmymoney/widgets/register.cpp 1bdf5bd 
>   kmymoney/widgets/transactionform.cpp 642e98f 
> 
> Diff: http://git.reviewboard.kde.org/r/112364/diff/
> 
> 
> Testing
> -------
> 
> Extensive editing of sample files, and changing back and forth between different activity types, which tended to show
> problem areas. atype run.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130910/d47f67c3/attachment-0001.html>