[Kmymoney-devel] Review Request 108666: Fix StdAddressBook deprecation warnings

[Cristian Oneț]

În ziua de Lun 02 Sep 2013, la 10:14:30, David Houlden a scris:
> Hi Cristian,
> 
> Yes, it works if I make that change.
> 
> There are two files which need changing.
> kmymoney/dialogs/knewfiledlg.cpp
> kmymoney/wizards/newuserwizard/knewuserwizard.cpp
> 

Thanks, done [1].

Regards,
Cristian

[1] http://commits.kde.org/kmymoney/05f21db8a54fa47ce69360addd2eceb482f7a0e9

> Regards,
> Dave.
> 
> On Monday 02 September 2013 06:09:32 Cristian Oneț wrote:
> > I see, so if you change
> > 
> > #include "Akonadi/RecursiveItemFetchJob"
> > 
> > with
> > 
> > #include "../../akonadi/recursiveitemfetchjob.h"
> > 
> > then it should work. If this is true then we'll make this change in
> > order to keep 4.6 as a minimum requirement.
> > 
> > Regards,
> > Cristian
> > 
> > 2013/9/1 David Houlden <djhoulden at gmail.com>:
> > > Hi Cristian,
> > > 
> > > I have two systems here, both Slackware, one running KDE 4.6.5 and the
> > > other 4.8.5. Neither has the header file
> > > Akonadi/RecursiveItemFetchJob. I have got the header file
> > > recursiveitemfetchjob.h.
> > > 
> > > I agree that the class was added in 4.6 but the
> > > Akonadi/RecursiveItemFetchJob header did not get added until 4.9. Take
> > > a look at the kdepimlibs git repository at
> > > http://quickgit.kde.org/?p=kdepimlibs.git and check the branches for
> > > versions <4.9.
> > > 
> > > This is the commit that added Akonadi/RecursiveItemFetchJob to 4.9.
> > > http://quickgit.kde.org/?p=kdepimlibs.git&a=commit&h=e8e3968acd887ef23
> > > afc366f1a7f161f76cba023
> > > 
> > > Regards,
> > > Dave
> > > 
> > > On Sunday 01 September 2013 16:21:55 Cristian Oneț wrote:
> > >> Hi David,
> > >> 
> > >> According to [1] and [2] RecursiveItemFetchJob was added in 4.6. Did
> > >> you reconfigured your local sandbox correctly? Try to find the header
> > >> in your kdepimlibs include path.
> > >> 
> > >> Regards,
> > >> Cristian
> > >> 
> > >> [1]
> > >> http://api.kde.org/4.x-api/kdepimlibs-apidocs/akonadi/html/classAkona
> > >> di _1_1RecursiveItemFetchJob.html [2]
> > >> https://projects.kde.org/projects/kde/kdepimlibs/repository/changes/a
> > >> ko nadi/recursiveitemfetchjob.h?rev=KDE%2F4.6
> > >> 
> > >> 2013/9/1 David Houlden <djhoulden at gmail.com>:
> > >> > On Tuesday 30 July 2013 18:20:02 Cristian Oneț wrote:
> > >> >> Hi,
> > >> >> 
> > >> >> There are no more gcc warnings due to deprecated API usage [1]
> > >> >> which is nice but please let me know if everything works as
> > >> >> expected on your system. In case you are wondering which part of
> > >> >> KMyMoney is affected by this change it's the 'Load from
> > >> >> Addressbook' feature described here [2]
> > >> >> 
> > >> >> [1] http://build.kde.org/job/kmymoney_master/102/
> > >> >> [2]
> > >> >> http://kmymoney2.sourceforge.net/kde4/online-manual/firsttime.3.ht
> > >> >> ml
> > >> >> 
> > >> >> În ziua de Mar 30 Iul 2013, la 16:37:14, ați scris:
> > >> >> > This review has been submitted with commit
> > >> >> > ace6e9657a5bef10f3f3ca9b69afdae9df7ec209 by Cristian Oneț to
> > >> >> > branch master.
> > >> >> > 
> > >> >> > - Commit Hook
> > >> > 
> > >> > Cristian,
> > >> > 
> > >> > I just tried compiling git master for the first time since you
> > >> > commited this change. I am getting the following error.
> > >> > 
> > >> > [ 43%] Building CXX object
> > >> > kmymoney/dialogs/CMakeFiles/dialogs.dir/knewfiledlg.cpp.o
> > >> > /usr/local/src/extras/kmymoney-
> > >> > git/kmymoney/kmymoney/dialogs/knewfiledlg.cpp:36:41: fatal error:
> > >> > Akonadi/RecursiveItemFetchJob: No such file or directory
> > >> > compilation terminated.
> > >> > make[2]: ***
> > >> > [kmymoney/dialogs/CMakeFiles/dialogs.dir/knewfiledlg.cpp.o] Error 1
> > >> > make[1]: *** [kmymoney/dialogs/CMakeFiles/dialogs.dir/all] Error 2
> > >> > make: *** [all] Error 2
> > >> > 
> > >> > This is on KDE 4.6.5 and the comments on the commit say that the
> > >> > minimum version of KDE required is 4.6. However, as far as I can
> > >> > see, the included file Akonadi/RecursiveItemFetchJob did not
> > >> > appear in kdepimlibs until version 4.9.
> > >> > 
> > >> > Regards,
> > >> > Dave
-- 
Regards,

Cristian Oneț
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130902/bc1c4a06/attachment.sig>