[Kmymoney-devel] Review Request 112394: Get rid of an additional flag for webConnect handling

[Thomas Baumgart]

> On Sept. 1, 2013, 3:32 p.m., Cristian Oneț wrote:
> > I just got the idea by looking at the commit that the do {} while (cond); cold have been replaced with a while (cond) {}. I would always prefer a while for a do-while if they are equivalent.

In deed, they are in this case here. I did not see that. Feel free to change it (w/o another review needed).


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112394/#review39074
-----------------------------------------------------------


On Aug. 31, 2013, 7:10 p.m., Thomas Baumgart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112394/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 7:10 p.m.)
> 
> 
> Review request for KMymoney and Cristian Oneț.
> 
> 
> Description
> -------
> 
> This patch removes an unnecessary flag in the webConnect handling which has been introduced lately during a bugfix.
> 
> 
> Diffs
> -----
> 
>   kmymoney/kmymoney.h 88b05a1 
>   kmymoney/kmymoney.cpp d14f3e5 
> 
> Diff: http://git.reviewboard.kde.org/r/112394/diff/
> 
> 
> Testing
> -------
> 
> Compiles and links. No further testing done, because I don't have webConnect usage here. I want others to help out with the testing. That is why I post the patch here and don't commit directly.
> 
> 
> Thanks,
> 
> Thomas Baumgart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130901/7e252263/attachment.html>