[Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113143/
-----------------------------------------------------------

(Updated Oct. 20, 2013, 7:15 p.m.)


Review request for KMymoney.


Changes
-------

This is the second part patch, to install on top of part 1.  It deals with check numbering after a transaction deletion.


Bugs: 319801
    http://bugs.kde.org/show_bug.cgi?id=319801


Repository: kmymoney


Description
-------

If a user's sequence of check numbers is broken by, say 'ATM' or an invoice number such as 'No 123-001 ABC', the next check number produced will be '1', entries containing alpha or punctuation characters not being saved.
The fix corrects this by saving the complete entry, and uses any entered numeric part to calculate the next number in sequence.  If an existing numeric entry is edited, this entry will be taken into account for the next number.

There are some quirks.  If the entry which led to the current 'next number' is deleted, it is not possible to revert to the previous, now forgotten, 'next number', so the produced 'next number' is likely to leave a 'gap', and may need editing.  Also, there is no check that a new 'next number' does not already exist.  For instance, if there is the erroneous sequence 23,23,24, the 'next number' will be the expected 25.  However, if the user corrects the error by changing a 23 to 22, the new 'next number' will be 23, which also already exists.  I'm not sure if such issues, which exist also in the current release, are worthy of fixing for a fairly unimportant area, without becoming more involved.


Diffs
-----

  kmymoney/dialogs/transactioneditor.h f07dafb 
  kmymoney/dialogs/transactioneditor.cpp 71d94ec 
  kmymoney/kmymoneyutils.h f64a55e 
  kmymoney/kmymoneyutils.cpp 7058557 

Diff: http://git.reviewboard.kde.org/r/113143/diff/


Testing
-------

Many manual entries checked, including coping with all values in the unit tests.  The unit test runs OK.


File Attachments (updated)
----------------

Part 2
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/20/7aac2cee-e36f-466f-995f-d80c526094c3__0001-BUG-319801_REVIEW113143_-_Fix_losing_track_of_check_numberB.patch


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20131020/07d23350/attachment.html>