[Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/#review41094
-----------------------------------------------------------



kmymoney/dialogs/transactioneditor.cpp
<http://git.reviewboard.kde.org/r/112947/#comment30161>

    Why are you undoing this change I've made some days ago? https://projects.kde.org/projects/extragear/office/kmymoney/repository/revisions/092f3a79f4ec74d25e0f5a4b9c80dfef64db5da3
    
    Are you sure that you have the patch against master?



kmymoney/widgets/kmymoneydateinput.cpp
<http://git.reviewboard.kde.org/r/112947/#comment30162>

    This is part of a patch I posted for review, again are you sure that you have in this patch only your changes against master? https://git.reviewboard.kde.org/r/112989/



kmymoney/widgets/register.h
<http://git.reviewboard.kde.org/r/112947/#comment30163>

    Belongs to https://git.reviewboard.kde.org/r/112989/



kmymoney/widgets/register.cpp
<http://git.reviewboard.kde.org/r/112947/#comment30164>

    All the changes to this file belong to https://git.reviewboard.kde.org/r/112989/


It seems that there was a problem in the way you created the new patch. You mixed in some other patches and undid some recents commits with it so it can't be shipped unless you fix that.

- Cristian Oneț


On Oct. 1, 2013, 7:33 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112947/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2013, 7:33 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 322768
>     http://bugs.kde.org/show_bug.cgi?id=322768
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> - Interest category disappears -
> Steps to Reproduce:
> 1.Open a new Dividend transaction.
> 2.Enter an interest category and amount.
> 3.Enter a new fee category.
> 4.On accepting the new category, the interest category and amount have been cleared.
> One line fix in kmymoney/dialogs/transactioneditor.cpp.
> 
> - Fixes for KEditWidget visibility issues.
>  When editing an investment transaction, interest or fee edit widgets show or hide incorrectly.  This is a fairly long-standing issue, and there have been attempts to fix by delaying the show() or hide() instructions.  This became more pronounced during work to allow column resizing, and Cristian produced a fix for the root cause.  This fix is included here.
> With the above fix in place, it became necessary to revert the delayed show() and hide() calls, and this has been done.
> Of course, nothing is ever as simple as that, and another couple of issues emerged.  Whether or not an interest or fee amount widget is shown depends on the presence or absence of the associated category's text.  It transpired that if, say, an existing Reinvest transaction was edited to be, say a Buy transaction,  the text from the Reinvest interest category was seen by the new Buy entry and resulted in the interest-amount widget being visible when none should appear.  Similarly, if a transaction with a fee set is edited to be a type with no fee expected, for instance, an Add or RemoveShares, then the fee-amount widget became visible when not needed.
> It was necessary to rework the slotUpdateFeeVisibility() and slotUpdateInterestVisibility() functions to take account of the new transaction type.
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/investactivities.cpp 50f33ed 
>   kmymoney/dialogs/investtransactioneditor.h 3e62c2a 
>   kmymoney/dialogs/investtransactioneditor.cpp e9f87fb 
>   kmymoney/dialogs/transactioneditor.cpp cfb0f71 
>   kmymoney/widgets/kmymoneydateinput.cpp 856efaa 
>   kmymoney/widgets/register.h 50ce759 
>   kmymoney/widgets/register.cpp d5dd639 
>   kmymoney/widgets/transactioneditorcontainer.h f77b195 
>   kmymoney/widgets/transactionform.cpp 642e98f 
> 
> Diff: http://git.reviewboard.kde.org/r/112947/diff/
> 
> 
> Testing
> -------
> 
> Entering and editing various transaction types to ensure only the appropriate widgets became visible or hidden when required.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20131002/3322b157/attachment-0001.html>