[Kmymoney-devel] [kmymoney4] [Bug 327806] Investment transactions dropped without notification during import.

[allan]

https://bugs.kde.org/show_bug.cgi?id=327806

--- Comment #3 from allan <agander93 at gmail.com> ---
@Thomas again, please.
I've replaced the 
" KMessageBox::information(0, i18n("This investment account does not contain
the \"%1\" security.  Transactions involving this security will be ignored.",
statementTransactionUnderImport.m_strSecurity), i18n("Security not found"),
QString("MissingSecurity%1").arg(statementTransactionUnderImport.m_strSecurity.trimmed()));"
with 
"int ret = KMessageBox::warningContinueCancel(0, i18n("<center>This investment
account does not contain the \"%1\" security.</center>"
                                                        "<center>Transactions
involving this security will be ignored.</center>",
statementTransactionUnderImport.m_strSecurity),
                                                        i18n("Security not
found"), KStandardGuiItem::cont(), KStandardGuiItem::cancel());
            if (ret == KMessageBox::Cancel) {
              m_userAbort = true;" to be less likely to allow the user to fall
into a trap, and this, from my point of view, seems much better, and was going
to ask if it was OK to go ahead.

However, something a bit unexpected has happened.  Having installed Chris
Tucker's patch and my additions - see Bug 328127 - mymoneystatementreader.cpp
matching problem -
when I came back to this and tested again, instead of encountering the new
messagebox when importing into the 'wrong' investment account, instead the
imported transaction resulted in the creation of the new security in that
investment account.

In a way, this could be useful in creating a new investment on the fly,
although it might not be so good if it has done this in the 'wrong account',
ie, the user made a mistake.  I see no warning on the console of what was
happening, and I'm inclined to accept this 'new functionality', but to add a
warning message box for the user to accept or cancel.

Any thoughts, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.