[Kmymoney-devel] feature request

[aga]

On Sat, 11 May 2013 21:18:36 -0400
Jack <ostroffjh at sbcglobal.net> wrote:

> On 2013.05.11 20:57, Doug Lytle wrote:
> > aga wrote:
> >> I don't see that, exactly.
> > 
> > I do,
> > 
> > I'm running KMyMoney 4.6.3.  My last check number is 2801 (Written
> > to CBPU).  I have several (Online PMT), (Deposit) and (Debit Card)
> > after that.
> > 
> > When I do a new transaction for CBPU matching the previous  
> > transaction, the next check number is 1.
> > 
> I suspect it may be different editing an existing transaction from  
> entering a new one.  Entering a new transaction, if you change the  
> offered number, it probably alters what is remembered as the highest  
> used number.  I believe I've gotten into situations where it tried
> to use an already used number, because I missed a check, and entered
> it out of order, after I had entered later checks.
> 
> Jack

Yes and no.

I think the difference was more to do with the position of the within
the ledger.  Editing a transaction no could result in that item moving
up the sort order.  Then, another transaction with a valid number may
subsequently be found, and then the sequencing will restart.

The main problem though, is that there is this comment -
"
// if a new transaction has a valid number, keep it with the account"

and the test is -
"
if (!number.isEmpty())"

so any non-numeric value would get stored.  When that value was
encountered in a subsequent new transaction, it would be treated as
zero, and the number '1' would be the default entry.

I've changed it to store only an integer value, and that seems to work
as required.  But, might a user want to have a number with a decimal
 symbol in it?  I've tried that too, saving a double, and the decimal
 part now gets incremented.

So, who wants what?

Allan