[Kmymoney-devel] Review Request 109043: Fix various problems where the Enter button is enabled prematurely, or not enabled when it was required. Enable tabs when in multi-transaction edit with transaction form.

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109043/
-----------------------------------------------------------

(Updated March 8, 2013, 12:05 a.m.)


Review request for KMymoney.


Changes
-------

This is the revised patch to deal with the case where the Enter button was not being enabled when the transaction form was not in use and the amount was entered as the last field edited.
It also fixes Bug 316111, where an edit to the fee field in a Dividend was being ignored.


Description
-------

When not using the transaction form, it is possible to enter just an amount, and immediately the Enter button becomes enabled.  This is not the case when using the transaction form. The Enter button only becomes enabled when other fields are added.

Some other discrepancies also were noticed, both when using the transaction form, and when not.

1a) Enter a payee. That's OK.
1b) Now enter a single character in the memo.  Enter enabled.
2a) Enter a memo character. That's OK.
2b) Now enter a payee. That's still OK.
2c) Now enter another memo character.  Enter enabled.
3a) Enter an account.    Enter enabled.
4a) Enter a tag.    Enter enabled.

Also, when using the transaction form and doing a multi-transaction edit, on attempting to enter an amount, it was not accepted unless the amount was negative.
In the same area, the tabs are not enabled.

Investment entry seems OK. 


This addresses bugs 314955 and 316111.
    http://bugs.kde.org/show_bug.cgi?id=314955
    http://bugs.kde.org/show_bug.cgi?id=316111


Diffs (updated)
-----

  kmymoney/dialogs/investactivities.cpp 6035d11 
  kmymoney/dialogs/transactioneditor.cpp a6d7432 
  kmymoney/widgets/register.cpp c167bcd 

Diff: http://git.reviewboard.kde.org/r/109043/diff/


Testing
-------

Performed numerous edits both with and without the transaction form, and single and multiple transactions.  Imports of QIF and CSV files done.


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130308/dcf8b832/attachment.html>