[Kmymoney-devel] Review Request 109043: Fix various problems where the Enter button is enabled prematurely, or not enabled when it was required. Enable tabs when in multi-transaction edit with transaction form.

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109043/#review28740
-----------------------------------------------------------


I've built KMM using your patch and made some plausibility checks regarding the transaction editor for single and multiple transactions.

   I could not find a case anymore which looked odd to me.

This was tested in ledger with a normal asset account.

- Marko Käning


On Feb. 19, 2013, 5:27 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109043/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 5:27 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> When not using the transaction form, it is possible to enter just an amount, and immediately the Enter button becomes enabled.  This is not the case when using the transaction form. The Enter button only becomes enabled when other fields are added.
> 
> Some other discrepancies also were noticed, both when using the transaction form, and when not.
> 
> 1a) Enter a payee. That's OK.
> 1b) Now enter a single character in the memo.  Enter enabled.
> 2a) Enter a memo character. That's OK.
> 2b) Now enter a payee. That's still OK.
> 2c) Now enter another memo character.  Enter enabled.
> 3a) Enter an account.    Enter enabled.
> 4a) Enter a tag.    Enter enabled.
> 
> Also, when using the transaction form and doing a multi-transaction edit, on attempting to enter an amount, it was not accepted unless the amount was negative.
> In the same area, the tabs are not enabled.
> 
> Investment entry seems OK. 
> 
> 
> This addresses bug 314955.
>     http://bugs.kde.org/show_bug.cgi?id=314955
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp a6d7432 
>   kmymoney/widgets/register.cpp c167bcd 
> 
> Diff: http://git.reviewboard.kde.org/r/109043/diff/
> 
> 
> Testing
> -------
> 
> Performed numerous edits both with and without the transaction form, and single and multiple transactions.  Imports of QIF and CSV files done.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130306/c7b6f37e/attachment-0001.html>