[Kmymoney-devel] Review Request 109918: Non-processing days no longer work for certain regions

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109918/#review33603
-----------------------------------------------------------

Ship it!


It looks fine to me. Go ahead and push it to master.

- Alvaro Soliverez


On April 8, 2013, 10:27 p.m., Ian Neal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109918/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 10:27 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> On KDE 4.10.1 setting of a holiday region to United Kingdom no longer makes public holidays non-processing days.
> This patch: 
> * Makes use of new HolidayRegion API to generate list of regions with languages for holiday region selector in schedule settings pane.
> I believe the new API was added in KDE 4.5
> 
> 
> This addresses bug 317682.
>     http://bugs.kde.org/show_bug.cgi?id=317682
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/settings/ksettingsschedules.cpp b57d5dd 
> 
> Diff: http://git.reviewboard.kde.org/r/109918/diff/
> 
> 
> Testing
> -------
> 
> Tested against recent git master compiled on KDE 4.10.1
> Needs to be tested against other KDE versions 4.5 upwards but I only have access to 4.10.1
> 
> 
> Thanks,
> 
> Ian Neal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130603/5f35be61/attachment.html>