[Kmymoney-devel] Review Request 108396: remove unused file

[Łukasz Maszczyński]

> On Jan. 14, 2013, 6:25 a.m., Thomas Baumgart wrote:
> > Since all methods are pure virtual this header describes an interface. It is implemented in mymoneystatementreader.h but usage of the interface description is not enforced. I don't know why. Before we remove the file, we should check if it contains documentation that is not part of mymoneystatementreader.h and move it over. Otherwise, I don't see a problem with removing the file.

There are 4 identical methods in IMyMoneyReader and MyMoneyStatementReader, but there's nothing useful in the documentation - meaning the methods are either not documented at all (in both classes), or doxygen comments are copy-pasted.

The remainder of the interface is different from methods in MyMoneyStatementReader, so it seems to be just a concept that the author was planning to introduce, but never did. 


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108396/#review25420
-----------------------------------------------------------


On Jan. 13, 2013, 7:08 p.m., Łukasz Maszczyński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108396/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 7:08 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> removed file kmymoney/converter/imymoneyreader.h which is not used anywhere in the project
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/imymoneyreader.h 6c1a61936c795997ae09fe06882e24459fa7e886 
> 
> Diff: http://git.reviewboard.kde.org/r/108396/diff/
> 
> 
> Testing
> -------
> 
> compile from clean workspace
> 
> 
> Thanks,
> 
> Łukasz Maszczyński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130117/10ec1ad5/attachment.html>