[Kmymoney-devel] Review Request 107714: BUG:311481 - Fix problem in Schedules where the name field may be empty but OK button is enabled. Also, the amount field affects the OK button status.

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107714/
-----------------------------------------------------------

(Updated Jan. 12, 2013, 12:07 p.m.)


Review request for KMymoney.


Changes
-------

As the previous patch has been committed, this patch is additional.
It removes calls to slotUpdateButtonState() from remaining non-mandatory widgets, because of
(expected) further issues.
I'm not sure, either, that the Tag widget operation is as expected, in that any entered text
is cleared if another editable widget is selected, or if tab is clicked.  Should the user be
cautioned, as for the payee?  I'll leave that for the author.


Description
-------

The problem as originally reported was that in Schedules view, the OK button became enabled even though no schedule name had been entered.

It was found that the button became enabled as soon as a payee was entered.  It was also found that this happened when an amount was entered.

For "payee", line 753 of transactioneditor.cpp has - 
"connect(payee,SIGNAL(textChanged(QString)),this,SLOT(slotUpdateButtonState()))", and slotUpdateButtonState() has - 
"emit transactionDataSufficient(isComplete(reason)", 
and 'This signal is sent out whenever enough data is present to enter the transaction into the ledger.'

Similarly, for "amount", at line 826, the same line appears.

As neither of these fields is a mandatory one, I believe they should not affect the OK button status.  So, as shown in the patch, I have temporarily disabled these lines.  I have done numerous tests of schedule creation and editing, and manual entry and editing of transactions without any problem.

The same area of code in transactioneditor.cpp has several more of these possibly unneeded lines, although not affecting schedules.  For instance, even with these two lines out and with no mandatory fields completed, if a payee is selected and the memo, tag field, next due date or status is edited, the OK button again is enabled wrongly.

I don't really see any valid reason for 'slotUpdateButtonState()' to be in this section.  What do the wise men think?


This addresses bug 311481.
    http://bugs.kde.org/show_bug.cgi?id=311481


Diffs (updated)
-----

  kmymoney/dialogs/transactioneditor.cpp 8f6f06b 

Diff: http://git.reviewboard.kde.org/r/107714/diff/


Testing
-------

Numerous tests of schedule creation and editing, and manual entry and editing of transactions without any problem.


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130112/e1382585/attachment.html>