[Kmymoney-devel] Review Request: BUG:311481 - Fix problem in Schedules where the name field may be empty but OK button is enabled. Also, the amount field affects the OK button status.

[Alvaro Soliverez]

> On Jan. 8, 2013, 9:02 p.m., Alvaro Soliverez wrote:
> > I say the rationale is sound, the payee should not affect the button state.
> > But it would be good to know why the schedule name is not checked when updating the button states
> 
> Allan Anderson wrote:
>     Sorry, I accidentally skirted round that by commenting only on what seemed to be incorrect.  In fact, there is no problem with the schedule name.  slotUpdateButtonState() is called whenever the text of schedule name is entered or edited.  However, that was not apparent because the button had already been enabled, wrongly, by other non-mandatory widgets.
>
> 
> Allan Anderson wrote:
>     Am I OK to ship now, please?  I just have to remove the instructions that I'd commented out.
>     
>     I'm inclined to leave for later this area -  "The same area of code in transactioneditor.cpp has several more of these possibly unneeded lines, although not affecting schedules.  For instance, even with these two lines out and with no mandatory fields completed, if a payee is selected and the memo, tag field, next due date or status is edited, the OK button again is enabled wrongly.
>     
>     I don't really see any valid reason for 'slotUpdateButtonState()' to be in this section.  What do the wise men think?"
>     
>     Yay or Nay?
>

That area of code is a big mess. For example, it's what took longer to migrate and stabilize in KDE4.
I'd say it's good enough for now.


- Alvaro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107714/#review25007
-----------------------------------------------------------


On Dec. 14, 2012, 10:46 a.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107714/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2012, 10:46 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> The problem as originally reported was that in Schedules view, the OK button became enabled even though no schedule name had been entered.
> 
> It was found that the button became enabled as soon as a payee was entered.  It was also found that this happened when an amount was entered.
> 
> For "payee", line 753 of transactioneditor.cpp has - 
> "connect(payee,SIGNAL(textChanged(QString)),this,SLOT(slotUpdateButtonState()))", and slotUpdateButtonState() has - 
> "emit transactionDataSufficient(isComplete(reason)", 
> and 'This signal is sent out whenever enough data is present to enter the transaction into the ledger.'
> 
> Similarly, for "amount", at line 826, the same line appears.
> 
> As neither of these fields is a mandatory one, I believe they should not affect the OK button status.  So, as shown in the patch, I have temporarily disabled these lines.  I have done numerous tests of schedule creation and editing, and manual entry and editing of transactions without any problem.
> 
> The same area of code in transactioneditor.cpp has several more of these possibly unneeded lines, although not affecting schedules.  For instance, even with these two lines out and with no mandatory fields completed, if a payee is selected and the memo, tag field, next due date or status is edited, the OK button again is enabled wrongly.
> 
> I don't really see any valid reason for 'slotUpdateButtonState()' to be in this section.  What do the wise men think?
> 
> 
> This addresses bug 311481.
>     http://bugs.kde.org/show_bug.cgi?id=311481
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp 72295a2 
> 
> Diff: http://git.reviewboard.kde.org/r/107714/diff/
> 
> 
> Testing
> -------
> 
> Numerous tests of schedule creation and editing, and manual entry and editing of transactions without any problem.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130110/178cba23/attachment-0001.html>