[Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

[Marko Käning]

> On Jan. 3, 2013, 6:55 p.m., Łukasz Maszczyński wrote:
> > Good, the tests are getting more and more readable with every update.

I see now that also testTwoInstitutions() and testOneInstitution() are interfering, like my tests did before.
These two tests are inherently also used inside testAddAccounts(), which complicates things further.

I guess it looks like the tests would need a general overhaul independent of what I am trying to implement here and I'd suggest to ship this patch for now and open a new review for further changes to other tests, which will be in any case a quite extensive project...


> On Jan. 3, 2013, 6:55 p.m., Łukasz Maszczyński wrote:
> > kmymoney/mymoney/mymoneyfiletest.cpp, lines 2084-2085
> > <http://git.reviewboard.kde.org/r/107619/diff/7/?file=104083#file104083line2084>
> >
> >     Extracting a hardcoded value (2011,12,1) to a variable (tDate) is a good idea - it improves readability, and the same object can be used many times if necessary.
> >     
> >     Now think of a better variable name so that the comment will no longer be needed (same applies to remaining two tests).
> 
> Marko Käning wrote:
>     Good point.
>     I'll do something about it.
>     
>     (The two issues at the bottom I won't touch until I get feedback from the other devs.)

Don't know why this issue is not registered as "Fixed", although I believe to have done so already yesterday.
(Clicking the button now doesn't do anything.)


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107619/#review24595
-----------------------------------------------------------


On Jan. 3, 2013, 7:45 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107619/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 7:45 p.m.)
> 
> 
> Review request for KMymoney and Łukasz Maszczyński.
> 
> 
> Description
> -------
> 
> The homepage accounts tables now show a different icon if there are transactions for an account after the last online transaction - highlighting for the user the necessity to download transactions in order to verify the account status.
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df 
>   kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd 
>   kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 
>   kmymoney/mymoney/mymoneyfiletest.cpp feb9d57ecd7156fc1eea189a905fa797aeae9183 
>   kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c 
> 
> Diff: http://git.reviewboard.kde.org/r/107619/diff/
> 
> 
> Testing
> -------
> 
> Built and ran application and test cases successfully.
> 
> 
> Screenshots
> -----------
> 
> example for the 4 possible cases of online status
>   http://git.reviewboard.kde.org/r/107619/s/948/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130104/1f6dd1aa/attachment.html>