[Kmymoney-devel] Review Request: Introduce new member function MyMoneyFile::countNotReconciledTransactions(const QString& accId)

[Marko Käning]

> On Jan. 4, 2013, 12:23 a.m., Alvaro Soliverez wrote:
> > I think it's the right place to add the method, as it's calculated on-the-fly. Otherwise it should go to MyMoneyAccount.
> > 
> > If possible, add a test for it.

Thanks for your immediate response, Alvaro.

As Thomas pointed out all methods in MyMoneyFile have to supply (a) test(s).

I'll implement it/them, of course, once I proceed with this little extension.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108150/#review24629
-----------------------------------------------------------


On Jan. 3, 2013, 10:27 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108150/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 10:27 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> I plan to introduce the new member function
> 
>   MyMoneyFile::countNotReconciledTransactions(const QString& accId)
> 
> which will do nothing else than counting the number of not reconciled transactions for a specific account.
> 
> 
> Before I proceed with the actual integration of data generated by this method into the homepage view's accounts tables (similar to [1]) I just want to ask here, whether this is actually the desired/required way to handle such a simple functionality?
> 
> 
> ---
> 
> [1] "homepage: extend accounts table with additional columns to reflect online-status" https://git.reviewboard.kde.org/r/107364/
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df 
>   kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd 
>   kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c 
> 
> Diff: http://git.reviewboard.kde.org/r/108150/diff/
> 
> 
> Testing
> -------
> 
> Simple test checked via qDebug() shows the desired functionality.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130104/561f59e2/attachment.html>