[Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

[Łukasz Maszczyński]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107619/#review24595
-----------------------------------------------------------


Good, the tests are getting more and more readable with every update.


kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18860>

    Extracting a hardcoded value (2011,12,1) to a variable (tDate) is a good idea - it improves readability, and the same object can be used many times if necessary.
    
    Now think of a better variable name so that the comment will no longer be needed (same applies to remaining two tests).



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18861>

    Does this impact the test at all? E.g. would it matter if you changed "Memotext" to something else or removed the line? (Applies to the next test as well)



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18862>

    In my opinion it's safe to assume that addSplit() won't throw, so I would skip the try-catch block here, as it makes the test a bit less readable. But it's also ok the way it is. (Same in the next test



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18863>

    What is the purpose of all the QVERIFY-s here? (Same in the next test)


- Łukasz Maszczyński


On Jan. 2, 2013, 10:49 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107619/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 10:49 p.m.)
> 
> 
> Review request for KMymoney and Łukasz Maszczyński.
> 
> 
> Description
> -------
> 
> The homepage accounts tables now show a different icon if there are transactions for an account after the last online transaction - highlighting for the user the necessity to download transactions in order to verify the account status.
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df 
>   kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd 
>   kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 
>   kmymoney/mymoney/mymoneyfiletest.cpp feb9d57ecd7156fc1eea189a905fa797aeae9183 
>   kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c 
> 
> Diff: http://git.reviewboard.kde.org/r/107619/diff/
> 
> 
> Testing
> -------
> 
> Built and ran application and test cases successfully.
> 
> 
> Screenshots
> -----------
> 
> example for the 4 possible cases of online status
>   http://git.reviewboard.kde.org/r/107619/s/948/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130103/a05d671f/attachment-0001.html>