[Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

[Łukasz Maszczyński]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107619/#review24488
-----------------------------------------------------------


I'll comment on the tests only, as the rest looks fine to me, including the screenshot!


kmymoney/mymoney/mymoneyfiletest.h
<http://git.reviewboard.kde.org/r/107619/#comment18781>

    Split is good, now I'd rename the methods to some more meaningful names, e.g. testHasNewerTransaction_noBalanceDifference() and *_withBalanceDifference()



kmymoney/mymoney/mymoneyfiletest.h
<http://git.reviewboard.kde.org/r/107619/#comment18782>

    You extracted a part of testAddAccounts() just fine, but please also update the original method to call AddOneAccount() so that there's no code duplication.



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18783>

    If you rename the methods, I think the comment will no longer be needed



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18790>

    This is nice - you don't use hardcoded value because you can get the actual id directly from the object



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18787>

    I think that dependency on test #1 could be easily removed - that's the right way to go, whenever it's possible.



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18784>

    If you rename the methods, I think the comment will no longer be needed



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18793>

    You use the same harcoded value in several places in the test - this is error prone and may require unnecessary maintenance effort in the future. Use a.id() as you did before.


- Łukasz Maszczyński


On Jan. 1, 2013, 9:13 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107619/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 9:13 p.m.)
> 
> 
> Review request for KMymoney and Łukasz Maszczyński.
> 
> 
> Description
> -------
> 
> The homepage accounts tables now show a different icon if there are transactions for an account after the last online transaction - highlighting for the user the necessity to download transactions in order to verify the account status.
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df 
>   kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd 
>   kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 
>   kmymoney/mymoney/mymoneyfiletest.cpp feb9d57ecd7156fc1eea189a905fa797aeae9183 
>   kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c 
> 
> Diff: http://git.reviewboard.kde.org/r/107619/diff/
> 
> 
> Testing
> -------
> 
> Built and ran application and test cases successfully.
> 
> 
> Screenshots
> -----------
> 
> example for the 4 possible cases of online status
>   http://git.reviewboard.kde.org/r/107619/s/948/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130102/bfe77b5d/attachment.html>