[Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

Marko Käning mk-lists at email.de
Tue Jan 1 12:58:16 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 1, 2013, 12:58 p.m.)

Review request for KMymoney.


I added the new method AddOneAccount() which is - exemplarily - used by two test cases for now.

I ask myself - since all the code was taken from testAddAccounts() - whether all the QVERIFYs in AddOneAccount() are actually still necessary...

This is just a starting point, still to be done is splitting up the various tests case into separate test functions as well as re-using AddOneAccount() for other test cases. 


The homepage accounts tables now show a different icon if there are transactions for an account after the last online transaction - highlighting for the user the necessity to download transactions in order to verify the account status.

Diffs (updated)

  kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df 
  kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd 
  kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 
  kmymoney/mymoney/mymoneyfiletest.cpp feb9d57ecd7156fc1eea189a905fa797aeae9183 
  kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c 

Diff: http://git.reviewboard.kde.org/r/107619/diff/


Built and ran application and test cases successfully.


Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130101/18835487/attachment.html>

More information about the KMyMoney-devel mailing list