[Kmymoney-devel] Bugfixing

[Thomas Baumgart]

Jeremy,

not sure if you're subscribed to the list, so I CC you here.

On Friday 27 December 2013 11:00:29 Jeremy Whiting wrote:

> Hello all,
> 
> I'd like to take a hand at fixing the issues with the loan editing
> wizard as reported here: [1][2]. Should I add a new page to the loan
> editor wizard that lets you change the account it's paying from and
> the institution (and other account) attributes? Or make it possible to
> bring up the account editor dialog with some options disabled? I'm
> fine to try either way, but thought I'd ask first so as to not waste
> time with the wrong/unwanted approach.

Thanks for your interest in helping out to improve the project. From a first 
guess I'd suggest to improve the existing loan editor wizard. Reason: 
otherwise you would have to figure out which editor to start when the user 
selects 'Edit...' on a loan account. You could add new options to the first 
page or add the page to one of the existing options.

If I were you, I would start with https://bugs.kde.org/show_bug.cgi?id=257619 
because it /only/ involves the account object and its reference to the 
institution. A simple call to MyMoneyFile::modifiyAccount() should already 
have all the functionality in the backend in case the institution is set in 
the MyMoneyAccount object passed as parameter.

https://bugs.kde.org/show_bug.cgi?id=294596 seems a bit more complex, as the 
schedule object and the account are not that tightly coupled as the 
institution and the account. I don't have a schedule for a loan anymore at 
hand here in my file, but assume, that only the schedule object needs to be 
changed in this case. I can't remember if editing loan schedules is blocked at 
all or what. But I would think, changing the schedule editor to allow 
modifying certain parts of a loan schedule would do the job.

Hope that answers your question. I suggest you upload your patches to 
reviewboard and have us take a look. In case you have questions, just drop 
them here on the developer list.

> P.S. I've been using KMyMoney from git for years now, and couldn't be
> happier with it besides these few minor papercuts. Which is why I'd
> like to fix them.
> 
> 1. https://bugs.kde.org/show_bug.cgi?id=294596
> 2. https://bugs.kde.org/show_bug.cgi?id=257619

-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
Q: Do you know the golden rule?
A: The rules are made by those who own the gold!
-- Frank Stornach
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20131228/8db30c74/attachment.sig>