[Kmymoney-devel] Review Request 112026: Move XDG icons to icons/xdg, drop unused icon

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112026/#review37745
-----------------------------------------------------------


Do we need to inform packagers about changed locations? Or is their job not affected by this change? Other than that, the patch looks good to me with one question left open.


kmymoney/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112026/#comment27955>

    What about this line (#77)? Doesn't that need to be adjusted as well if you move the icons into their own directory?


- Thomas Baumgart


On Aug. 12, 2013, 1:16 p.m., Yury Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112026/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 1:16 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> 
> This way icons are not mixed with sources in `ls` output.
> git pull kde:clones/kmymoney/kudryashov/kmymoney move-icons
> to see moved files not as removed & created
> 
> 
> Diffs
> -----
> 
>   kmymoney/CMakeLists.txt 593cda911041ba74303405b042465e66095269b1 
>   kmymoney/hi128-app-kmymoney.png 8831c8984fe043f6fa95c68c5502931009b743fc 
>   kmymoney/hi128-mimetypes-application-x-kmymoney.png b7b07754c92fc257419ff26d343d899e44666e27 
>   kmymoney/hi16-app-kmymoney.png 602dfe2c6138925bfab0f658ef590d7796fdb4d9 
>   kmymoney/hi16-mimetypes-application-x-kmymoney.png 6ba3367e88a18b272a48c2dd4b19103b040047cc 
>   kmymoney/hi22-mimetypes-application-x-kmymoney.png 9e2a8a463d8e60ade5d952a08fe33d27c2c692a8 
>   kmymoney/hi32-app-kmymoney.png 2c094bd6e3a6b8838eeb4c316e6b4af76e97baef 
>   kmymoney/hi32-mimetypes-application-x-kmymoney.png 13a8bd2a9e8c106098cfef0178130c1de84eb9f8 
>   kmymoney/hi48-app-kmymoney.png 5d3dd78a57dca266b5da5153a036783b25f243a1 
>   kmymoney/hi48-mimetypes-application-x-kmymoney.png d362bf40b93549ac331f282e9bf337784370bf23 
>   kmymoney/hi64-app-kmymoney.png c92938c8659e835b1941dfdf1072daacfa4cc008 
>   kmymoney/hi64-mimetypes-application-x-kmymoney.png f045903d8b91d88db677d768ff1f6fb633230bed 
>   kmymoney/icons/CMakeLists.txt PRE-CREATION 
>   kmymoney/icons/xdg/CMakeLists.txt PRE-CREATION 
>   kmymoney/icons/xdg/hi128-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi128-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi16-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi16-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi22-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi32-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi32-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi48-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi48-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi64-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi64-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/lo16-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/lo32-app-kmymoney.png PRE-CREATION 
>   kmymoney/kmymoney_wizard.png be61ab7d4696c40edfe08b64b373b2c1c1a0aa08 
>   kmymoney/lo16-app-kmymoney.png 5a245b70bfde4eff384b56b027837ceec710459f 
>   kmymoney/lo32-app-kmymoney.png 2c094bd6e3a6b8838eeb4c316e6b4af76e97baef 
> 
> Diff: http://git.reviewboard.kde.org/r/112026/diff/
> 
> 
> Testing
> -------
> 
> cmake ..; make; make instal
> 
> 
> Thanks,
> 
> Yury Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130814/7035c944/attachment.html>