[Kmymoney-devel] Review Request 109803: Add CSV export capability.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109803/#review31509
-----------------------------------------------------------


Unless you want the member vars public you should really make them private. The sorting issue inside the while-loop is also something you should look into. The other things I commented on are just nitpicks and I don't mind if you leave them the way you have hem now.


kmymoney/plugins/csvexport/csvexportdlg.h
<http://git.reviewboard.kde.org/r/109803/#comment23467>

    You should not make member vars public. Simply move those two declarations to the bottom where all the other member var m_idList is declared.



kmymoney/plugins/csvexport/csvexportdlg.cpp
<http://git.reviewboard.kde.org/r/109803/#comment23468>

    This sorting still happens inside the while loop. Or am I missing sth. here?



kmymoney/plugins/csvexport/csvexporterplugin.h
<http://git.reviewboard.kde.org/r/109803/#comment23469>

    Public member vars



kmymoney/plugins/csvexport/csvwriter.cpp
<http://git.reviewboard.kde.org/r/109803/#comment23470>

    Not sure if debug messages need to be translated. This is debatable.



kmymoney/plugins/csvexport/csvwriter.cpp
<http://git.reviewboard.kde.org/r/109803/#comment23471>

    why not using "\n\n" instead? Your way needs one more byte of mem plus cpu time during each call.



kmymoney/plugins/csvexport/csvwriter.cpp
<http://git.reviewboard.kde.org/r/109803/#comment23472>

    Here's another way to do this:
    
      str += QString("\"%1\",").arg(payee.name());
    
    Don't know which one is better.


- Thomas Baumgart


On April 24, 2013, 6:16 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109803/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 6:16 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Add CSV export capability.  Modify existing KMyMoney File menu in order to make menu item positions more logical.
> 
> 
> This addresses bug 317614.
>     http://bugs.kde.org/show_bug.cgi?id=317614
> 
> 
> Diffs
> -----
> 
>   kmymoney/kmymoneyui.rc f353641 
>   kmymoney/plugins/CMakeLists.txt 81ca458 
>   kmymoney/plugins/csvexport/CMakeLists.txt PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexportdlg.h PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexportdlg.cpp PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexportdlg.ui PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterplugin.h PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterplugin.cpp PRE-CREATION 
>   kmymoney/plugins/csvexport/csvwriter.h PRE-CREATION 
>   kmymoney/plugins/csvexport/csvwriter.cpp PRE-CREATION 
>   kmymoney/plugins/csvexport/kmm_csvexport.desktop PRE-CREATION 
>   kmymoney/plugins/csvexport/kmm_csvexport.rc PRE-CREATION 
>   kmymoney/plugins/csvimport/investprocessing.cpp 07d4d82 
>   kmymoney/plugins/csvimport/kmm_csvimport.rc d678169 
> 
> Diff: http://git.reviewboard.kde.org/r/109803/diff/
> 
> 
> Testing
> -------
> 
> Exported numerous checking and investment CSV files, and then imported into KMyMoney via CSV import (discovering a few minor issues in the existing KMyMoney accounts in the process.)
> Ran astyle and Krazy2.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130424/fbf2adf4/attachment-0001.html>