[Kmymoney-devel] [kmymoney4] [Bug 317511] cannot edit transaction from ledger view after double-clicking on category in category list

[allan]

https://bugs.kde.org/show_bug.cgi?id=317511

allan <agander93 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agander93 at gmail.com

--- Comment #4 from allan <agander93 at gmail.com> ---
I'm posting a couple of messages from the list, which, towards the end, relate
to editing transactions selected via Category view.  To summarise, it may be
possible to remove this restriction, but only when more developer time is
available.
"
> Thomas Baumgart <thb at net-bembel.de> wrote:  
> > Hi Allen et al,
> > 
> > On Thursday 18 April 2013 12:20:47 aga wrote:  
> > > While investigating the reason why it was not possible to edit
> > > multiple investment transactions, I noticed that there was quite a
> > > number of tooltips in the code that appeared to be non-functional.
> > > For instance, if one of the transactions involved a closed account,
> > > or if the chosen transactions were not of the same type.  In those
> > > cases, and others, editing was disabled, but no tooltip appeared on
> > > the transactions to explain.
> > > 
> > > I was expecting the tooltip to appear this way, in the same way
> > > that a missing category/account assignment is flagged.  So, I
> > > implemented a fairly simple way to achieve that.  Then, I noticed
> > > that, having deliberately selected two transactions that were not
> > > of the same type, the Edit button was correctly disabled, but,
> > > provided one first clicked in the body of the transactions view, a
> > > tooltip did appear, on the Edit button, although with an invalid
> > > message indicating 'Duplicate the current selected transactions'.
> > > 
> > > What I'm suggesting is to combine the two methods, one which gives a
> > > more obvious hint, and the other, existing one, which might still
> > > have a valid purpose.
> > > 
> > > Any thoughts, anyone?  
> > 
> > More and more I get the feeling, that this whole ledger business
> > comes to ages. Many things have been put in there and you stepped on
> > another one of those features. They are around since the KDE3 days
> > and might not have been ported to their full functioning into KDE4. I
> > don't want to blame anyone who worked on the KDE4 port as this was a
> > large job by itself.
> > 
> > Before putting any more effort into getting the existing stuff
> > working, I suggest to re-work the whole ledger view to be based on
> > the MVC paradigm and use the existing Qt4 mechanisms more
> > effectively. I expect a performance boost of the ledger view as a
> > side effect, btw.
> > 
> > Just my 0.02  
> 
> Not any time soon, though, I suspect?
> 
> What about other ledger area issues?  eg.
> https://bugs.kde.org/show_bug.cgi?id=317511 , although the question
> about being able to edit transactions selected via Category view may
> not be a Ledger issue.  What is the rationale for this restriction?  

I think we introduced this restriction way back in the 3.x days for usability 
reasons. All of us did not understand accounting principles too well then 
(which fortunately has changed due to the work on this project) and always had 
the vision that one needs an account to move money. Well, today we know that 
categories are simply accounts as well accounting wise and could probably lift 
that restriction. But we would have to check all the UI stuff that is still 
based on the restriction. Since the ledger view is the area that is affected 
the most by such a change and my feeling about a rewrite (see above) of that 
view lets me postpone the introduction of that feature for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.