[Kmymoney-devel] Review Request 109803: Add CSV export capability.

[Alvaro Soliverez]

> On April 19, 2013, 11:54 a.m., Cristian Oneț wrote:
> > csvexportdlgdecl.ui is not in the patch. Please provide the full patch against git master not only of your latest commit:
> > $git format-patch origin/master
> 
> Allan Anderson wrote:
>     It definitely shows as being in the first patch, on which the second patch is based.  When I do 
>     git format-patch origin/master -o ~/ , I get the two patch files as in this review. -
>     
>     /home/aga/0001-BUG-317614-Add-CSV-export-capability.patch
>     /home/aga/0002-BUG-317614-Add-CSV-export-capability-minor-changes-f.patch
>     
>     ~/Git/kmymoney $ git log
>     commit ad1cabdd80298588a4cbeec19689f5e0e738139d
>     Author: Allan Anderson <agander93 at gmail.com>
>     Date:   Fri Apr 19 12:25:10 2013 +0100
>     
>         BUG:317614 - Add CSV export capability - minor changes following Reviewboard.
>     
>     commit 45a3330ab990b9f6c7839ed2ad487ee0fed8299a
>     Author: Allan Anderson <agander93 at gmail.com>
>     Date:   Sat Mar 30 18:10:09 2013 +0000
>     
>         BUG:317614 - Add CSV export capability
>     
>     Does not that look correct?
>
> 
> Cristian Oneț wrote:
>     Although combining the two patches produces the correct result it's pretty hard to make a review based on it.
> 
> Cristian Oneț wrote:
>     You could have used 'git commit --amend' when committing the minor changes to update your previous commit (you can do that for commits that were not yet pushed).

You can also add multiple commits in one patch

git format-patch -2 > file.patch

This will create a patch with the 2 latest commits


- Alvaro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109803/#review31282
-----------------------------------------------------------


On April 19, 2013, 11:39 a.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109803/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 11:39 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Add CSV export capability.  Modify existing KMyMoney File menu in order to make menu item positions more logical.
> 
> 
> This addresses bug 317614.
>     http://bugs.kde.org/show_bug.cgi?id=317614
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvexport/CMakeLists.txt PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexportdlg.h PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexportdlg.cpp PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterrc PRE-CREATION 
>   kmymoney/plugins/csvexport/csvwriter.h PRE-CREATION 
>   kmymoney/plugins/csvexport/csvwriter.cpp PRE-CREATION 
>   kmymoney/plugins/csvexport/kmm_csvexport.desktop PRE-CREATION 
>   kmymoney/plugins/csvexport/ui_csvexportdlgdecl.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109803/diff/
> 
> 
> Testing
> -------
> 
> Exported numerous checking and investment CSV files, and then imported into KMyMoney via CSV import (discovering a few minor issues in the existing KMyMoney accounts in the process.)
> Ran astyle and Krazy2.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130419/537e6da5/attachment.html>