[Kmymoney-devel] Review Request 109803: Add CSV export capability.

[Allan Anderson]

> On April 19, 2013, 7:25 a.m., Cristian Oneț wrote:
> >
> 
> Allan Anderson wrote:
>     If you're happy with below, I'll ship later.
> 
> Cristian Oneț wrote:
>     Please update the patch in this review before shipping it.

Will now update the patch.


> On April 19, 2013, 7:25 a.m., Cristian Oneț wrote:
> > kmymoney/plugins/csvexport/kmm_csvexport.desktop, line 56
> > <http://git.reviewboard.kde.org/r/109803/diff/1/?file=126757#file126757line56>
> >
> >     Please remove the translations (all [lang] entries) since they will be handled by the translation teams.
> 
> Allan Anderson wrote:
>     Ah, OK.  I've left in (for now) Name[x-test]=xxcsvexportxx and Comment[x-test]=xxAdd CSV exporting to KMyMoneyxx as I don't know what they are.
> 
> Cristian Oneț wrote:
>     x-test is a translations extraction test language. To test that all strings are correctly extracted into the translation catalogs one can set the language to x-test and should see the original strings enclosed in XX...XX and the application can be visually checked for missing strings from translation.

OK, thanks.  I'll remove them, too.  Haven't seen them before.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109803/#review31271
-----------------------------------------------------------


On March 30, 2013, 6:42 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109803/
> -----------------------------------------------------------
> 
> (Updated March 30, 2013, 6:42 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Add CSV export capability.  Modify existing KMyMoney File menu in order to make menu item positions more logical.
> 
> 
> This addresses bug 317614.
>     http://bugs.kde.org/show_bug.cgi?id=317614
> 
> 
> Diffs
> -----
> 
>   kmymoney/kmymoneyui.rc f353641 
>   kmymoney/plugins/CMakeLists.txt 81ca458 
>   kmymoney/plugins/csvexport/CMakeLists.txt PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexportdlg.h PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexportdlg.cpp PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexportdlgdecl.ui PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterplugin.h PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterplugin.cpp PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterrc PRE-CREATION 
>   kmymoney/plugins/csvexport/csvwriter.h PRE-CREATION 
>   kmymoney/plugins/csvexport/csvwriter.cpp PRE-CREATION 
>   kmymoney/plugins/csvexport/kmm_csvexport.desktop PRE-CREATION 
>   kmymoney/plugins/csvexport/kmm_csvexport.rc PRE-CREATION 
>   kmymoney/plugins/csvexport/ui_csvexportdlgdecl.h PRE-CREATION 
>   kmymoney/plugins/csvimport/investprocessing.cpp 07d4d82 
>   kmymoney/plugins/csvimport/kmm_csvimport.rc d678169 
> 
> Diff: http://git.reviewboard.kde.org/r/109803/diff/
> 
> 
> Testing
> -------
> 
> Exported numerous checking and investment CSV files, and then imported into KMyMoney via CSV import (discovering a few minor issues in the existing KMyMoney accounts in the process.)
> Ran astyle and Krazy2.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130419/2467fe61/attachment.html>