[Kmymoney-devel] [kmymoney4] [Bug 317655] Various glitches with importing QIF from Quicken

[allan]

https://bugs.kde.org/show_bug.cgi?id=317655

--- Comment #19 from allan <agander93 at gmail.com> ---
(In reply to comment #18)
> > Hopefully, I'm not overlooking something.
> 
> Sadly, I was.  More investigation needed.

The original proposed fix did fix the initial duplication of sub-accounts on
their creation.  However, it caused another problem, with existing third and
subsequent level categories being dropped in Categories view.

So, the original fix was removed, allowing loading of sub-categories again. 
Instead, 
void loadSubAccounts(QStandardItemModel *model, QStandardItem *accountsItem,
QStandardItem *favoriteAccountsItem, const QStringList& list) was changed, to
detect attempts to load again a sub-category which had already been loaded.

Overall, the change is as follows -
 kmymoney/converter/mymoneyqifreader.cpp |    2 +-
 kmymoney/models/accountsmodel.cpp       |   21 ++++++++++++++++++---
 kmymoney/models/accountsmodel.h         |    1 +
 3 files changed, 20 insertions(+), 4 deletions(-)

So, it's not a huge change, but this is my first involvement with models, and
it may be that there is a better way.

I'll publish the patch here, but let me know if Reviewboard would be better.

-- 
You are receiving this mail because:
You are the assignee for the bug.