[Kmymoney-devel] Review Request 108489: added tests for transaction matching

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108489/
-----------------------------------------------------------

(Updated April 8, 2013, 2:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Description
-------

Added some tests to characterize application behavior regarding matching an imported transaction with existing/scheduled one.

I'd like to emphasize two important things in this review:
1. I've marked three tests with a comment "revise behavior", I believe they show unwanted behavior. Description of what I think should be expected is inside the test functions, so please comment those parts and let me know if my understanding is (in)correct.
2. I've removed a check, which I believe is superfluous - splitsReferenceSameAccount(), as transaction filter already takes care of filtering off the transactions which refer to a different account. I believe the 4 tests (*_accountMismatch_* and *_multipleAccounts_*) show that this check is not needed, however it was in the code for a long time, only rewritten during recent refactoring.


Diffs
-----

  kmymoney/converter/CMakeLists.txt 8433630af638df863dad55e10a3ead60f0b4c7f6 
  kmymoney/converter/matchfindertest.h PRE-CREATION 
  kmymoney/converter/matchfindertest.cpp PRE-CREATION 
  kmymoney/converter/transactionmatchfinder.h 5f276a846de4cc72bd2700f2560a64b8ee260217 
  kmymoney/converter/transactionmatchfinder.cpp 35e72cbc65dde762ed2e11651185afe2c4a14a3c 

Diff: http://git.reviewboard.kde.org/r/108489/diff/


Testing
-------

make test


Thanks,

Łukasz Maszczyński

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130408/5697e534/attachment.html>