[Kmymoney-devel] Review Request: Add a row with the total at the end of the payment and preferred accounts lists in the home view
Alvaro Soliverez
asoliverez at kde.org
Thu Sep 13 04:20:58 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106434/#review18920
-----------------------------------------------------------
kmymoney/views/khomeview.h
<http://git.reviewboard.kde.org/r/106434/#comment14998>
Why use a class property instead of using a local variable to store the total?
kmymoney/views/khomeview.h
<http://git.reviewboard.kde.org/r/106434/#comment14999>
Remove unneeded spaces. See other cases below
- Alvaro Soliverez
On Sept. 12, 2012, 11:47 p.m., Alessandro Russo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106434/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 11:47 p.m.)
>
>
> Review request for KMymoney.
>
>
> Description
> -------
>
> Add a row with the total at the end of the payment and preferred accounts lists in the home view
>
>
> Diffs
> -----
>
> kmymoney/views/khomeview.h ac78dfb
> kmymoney/views/khomeview.cpp ac1ae7a
>
> Diff: http://git.reviewboard.kde.org/r/106434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alessandro Russo
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120913/9ac2be55/attachment.html>
More information about the KMyMoney-devel
mailing list