[Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106846/#review20315
-----------------------------------------------------------


Some comments from end as well. The stuff you did looks very promissing. As Fernando already pointed out, unit tests are a must for the engine code (that found inside and underneath the mymoney subdir) before we will accept the patch.

Looking forward for more from your end.


kmymoney/kmymoney.h
<http://git.reviewboard.kde.org/r/106846/#comment16058>

    Extra (mostly trailing) spaces: there are a few of them around. One could use astyle-kmymoney.sh or the Kate option to automatically remove them.



kmymoney/mymoney/mymoneyfile.h
<http://git.reviewboard.kde.org/r/106846/#comment16055>

    Is it really 'institution' here?



kmymoney/mymoney/mymoneysplit.h
<http://git.reviewboard.kde.org/r/106846/#comment16057>

    Guess you will have to make this a list of tags in order to support multiple tags per transaction/split.


- Thomas Baumgart


On Oct. 14, 2012, 12:49 p.m., Alessandro Russo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106846/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2012, 12:49 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> 1) I created and almost completed the Tag tab in KMyMoneyView (KTagsView),
> it's similar to the payees tab.
> 2) I modified many classes in the storage folder and created a new class
> MyMoneyTag similar to MyMoneyPayee, now Tags save and load correctly but not
> all tag attribute (visibibleFrom,etc..) are saved/loaded yet.
> 3) I changed transactioneditor, transaction and KGlobalLedgerView, now there
> is a new widget called Tags in the translationeditor that someway works but
> no tags are shown in the ledger yet and no widget is showed when you insert
> or edit a transaction directly from the ledger (is this a feature that
> somebody uses?).
> 4) Missing features:
>   - multi tags per transaction (only 1 tag can be added at this time)
>   - no tag selection in reports
>   - hierarchical tags (I'm rethinking about the real usefulness of this
> one... as implementing it will require some work  )
>   - in the tag tab you can select a color for the tag, this will be used to
> show the tag in the ledger with this  color, also no visibility check is
> made.
>   - no tags in a split
>  Bugs:
>   - in the tag tab if you select a tag and click on the 'New tag' button the
> selected tag wil be deleted and replaced with an empy "NewTag"
>   - in the transaction editor when you edit a transaction with a tag the tag
> field is empty, when not in edit mode it show the tag name correctly.
>   - many more... 
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/CMakeLists.txt 9a8d782 
>   kmymoney/dialogs/ktagreassigndlg.h PRE-CREATION 
>   kmymoney/dialogs/ktagreassigndlg.cpp PRE-CREATION 
>   kmymoney/dialogs/ktagreassigndlgdecl.ui PRE-CREATION 
>   kmymoney/dialogs/transactioneditor.h 2535d96 
>   kmymoney/dialogs/transactioneditor.cpp 06c7fd1 
>   kmymoney/kmymoney.h 9482812 
>   kmymoney/kmymoney.cpp 1ef7400 
>   kmymoney/kmymoneyui.rc 4294c46 
>   kmymoney/mymoney/CMakeLists.txt d2917b5 
>   kmymoney/mymoney/mymoneyfile.h 6c1aa25 
>   kmymoney/mymoney/mymoneyfile.cpp eef7126 
>   kmymoney/mymoney/mymoneyobjectcontainer.h 21cd74c 
>   kmymoney/mymoney/mymoneyobjectcontainer.cpp 2e9c496 
>   kmymoney/mymoney/mymoneysplit.h ded6b4c 
>   kmymoney/mymoney/mymoneysplit.cpp 168d1e6 
>   kmymoney/mymoney/mymoneytag.h PRE-CREATION 
>   kmymoney/mymoney/mymoneytag.cpp PRE-CREATION 
>   kmymoney/mymoney/mymoneytransactionfilter.h 2a7b85d 
>   kmymoney/mymoney/mymoneytransactionfilter.cpp 6650fef 
>   kmymoney/mymoney/storage/imymoneyserialize.h ff49986 
>   kmymoney/mymoney/storage/imymoneystorage.h 8b980b7 
>   kmymoney/mymoney/storage/mymoneydatabasemgr.h ab587ed 
>   kmymoney/mymoney/storage/mymoneydatabasemgr.cpp f98a965 
>   kmymoney/mymoney/storage/mymoneyseqaccessmgr.h da67e58 
>   kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp 232d6b2 
>   kmymoney/mymoney/storage/mymoneystoragesql.h 73875b3 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 90ee818 
>   kmymoney/mymoney/storage/mymoneystoragexml.h 126cf8c 
>   kmymoney/mymoney/storage/mymoneystoragexml.cpp 88a02df 
>   kmymoney/views/CMakeLists.txt de0272f 
>   kmymoney/views/kgloballedgerview.cpp dfaecbd 
>   kmymoney/views/kmymoneyview.h 99ab398 
>   kmymoney/views/kmymoneyview.cpp 49dcc85 
>   kmymoney/views/ktagsview.h PRE-CREATION 
>   kmymoney/views/ktagsview.cpp PRE-CREATION 
>   kmymoney/views/ktagsviewdecl.ui PRE-CREATION 
>   kmymoney/widgets/kmymoney.widgets 857e42c 
>   kmymoney/widgets/kmymoneymvccombo.h 305e8a1 
>   kmymoney/widgets/kmymoneymvccombo.cpp 42a3687 
>   kmymoney/widgets/transaction.h a28053e 
>   kmymoney/widgets/transaction.cpp bfaafbf 
> 
> Diff: http://git.reviewboard.kde.org/r/106846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro Russo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121014/3ee6e4a6/attachment.html>