[Kmymoney-devel] Review Request: Tags: various bugs fix

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107373/#review22206
-----------------------------------------------------------



kmymoney/widgets/transaction.cpp
<http://git.reviewboard.kde.org/r/107373/#comment17094>

    If you set the ctx.palette to option palette the selected test is not needed anymore.



kmymoney/widgets/transaction.cpp
<http://git.reviewboard.kde.org/r/107373/#comment17093>

    I would go with the following code here:
    
    ctx.palette = option.palette;
    
    Just to make sure that we use all the stuff that is set in the palette before calling this function.
    



kmymoney/widgets/transaction.cpp
<http://git.reviewboard.kde.org/r/107373/#comment17096>

    Please remove the adjustment rect and use the document's margin to obtain the spacing by 2 pixels.



kmymoney/widgets/transaction.cpp
<http://git.reviewboard.kde.org/r/107373/#comment17095>

    ... and the commented code can be safely removed.


- Cristian Oneț


On Nov. 19, 2012, 12:44 a.m., Alessandro Russo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107373/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2012, 12:44 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Fixed:
>  - when closing the split dialog focus go to tag field and not to memo field
>  - if the user write in the tag line edit the name of a closed tag or of a tag already included in the transaction an information modal dialog will appear and the line edit will be cleared.
>  - restore right color for text in the ledger
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp 1a5e773 
>   kmymoney/widgets/kmymoneymvccombo.h ad6ae92 
>   kmymoney/widgets/kmymoneymvccombo.cpp 1053a1a 
>   kmymoney/widgets/transaction.cpp 7525851 
> 
> Diff: http://git.reviewboard.kde.org/r/107373/diff/
> 
> 
> Testing
> -------
> 
> Compile and run as intended.
> 
> 
> Thanks,
> 
> Alessandro Russo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121119/bb9b2ba4/attachment.html>