[Kmymoney-devel] Review Request: disallow single-space match key when matching payee by list of keys

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107138/#review22070
-----------------------------------------------------------



kmymoney/mymoney/mymoneypayee.cpp
<http://git.reviewboard.kde.org/r/107138/#comment16985>

    I haven't tested this code, but I could imagine that it would be necessary to specify the regexp as "^[^ ]*$" in order to be sure that single or multiply occurring spaces get really excluded - but nothing else.
    
    "[^ ]" would also match the strings " PAYMENT" and "PAYMENT " which you might not want to exclude.
    
    (Well, I haven't looked into QRegExp though to check whether my above regexp is correct in this case.)


- Marko Käning


On Oct. 30, 2012, 6:46 p.m., Łukasz Maszczyński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107138/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 6:46 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> There are three possible options when it comes to payee matching for imported transactions:
> 1. no matching
> 2. by payee name
> 3. by list of keys
> 
> When the 3rd option is selected it's easy to make a mistake and add a single space as the match key - the user is unlikely to realize this, as "space key" is not visible on the list (it's just a space, right?) unless selected. The consequence of this mistake is that nearly all transactions will match the payee (to be precise: all transactions which contain at least one space in the 'payee' field).
> 
> The "new" regular expression in the patch requires payee match key to contain at least a single non-space character.
> 
> This patch changes the algorithm of checking the match key: instead of joining multiple match keys into a single string separated with semicolons and matching the whole string with a regular expression, each match key is checked with a regular expression separaterly (results in a simpler regular expression).
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneypayee.cpp 93e12c8 
>   kmymoney/mymoney/mymoneypayeetest.h d50d61d 
>   kmymoney/mymoney/mymoneypayeetest.cpp 85ee7fd 
> 
> Diff: http://git.reviewboard.kde.org/r/107138/diff/
> 
> 
> Testing
> -------
> 
> new UT written
> make test
> 
> 
> Thanks,
> 
> Łukasz Maszczyński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121116/19f7c4d7/attachment-0001.html>