[Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft
Thomas Baumgart
thb at net-bembel.de
Tue Nov 6 14:44:27 UTC 2012
> On Nov. 6, 2012, 2:39 p.m., Thomas Baumgart wrote:
> > Things I found while running a few quick tests:
> >
> > - Startup with no tags available (my current file), select Tags view, right pane is enabled (should be disabled).
> > - Create a tag, delete it again. Now right pane is disabled
> >
> > - Create a new tag, the color button shows gray but when clicking, the color selector shows black (should be consistent)
> >
> > - while clicking through the application, I got the following error (whatever it means) on the console with a lockup:
> >
> > *** glibc detected *** kmymoney/kmymoney: invalid fastbin entry (free): 0x0000000002c9d0c0 ***
> >
> > was unable to reproduce it
> >
> > Other than that looks really good. We can certainly iron out some more of the details once the code is in the repository.
> >
Ooops, testcase failed :(
thb at thb-nb:~/devel/kmymoney/build> make test
Running tests...
Test project /home/thb/devel/kmymoney/build
Start 1: kmymoney-utilstest
1/29 Test #1: kmymoney-utilstest ........................ Passed 0.04 sec
Start 2: kmymoney-mymoneyaccounttest
2/29 Test #2: kmymoney-mymoneyaccounttest ............... Passed 0.02 sec
Start 3: kmymoney-mymoneyexceptiontest
3/29 Test #3: kmymoney-mymoneyexceptiontest ............. Passed 0.01 sec
Start 4: kmymoney-mymoneyfiletest
4/29 Test #4: kmymoney-mymoneyfiletest .................. Passed 0.02 sec
Start 5: kmymoney-mymoneyfinancialcalculatortest
5/29 Test #5: kmymoney-mymoneyfinancialcalculatortest ... Passed 0.02 sec
Start 6: kmymoney-mymoneyforecasttest
6/29 Test #6: kmymoney-mymoneyforecasttest .............. Passed 0.04 sec
Start 7: kmymoney-mymoneyinstitutiontest
7/29 Test #7: kmymoney-mymoneyinstitutiontest ........... Passed 0.02 sec
Start 8: kmymoney-mymoneykeyvaluecontainertest
8/29 Test #8: kmymoney-mymoneykeyvaluecontainertest ..... Passed 0.01 sec
Start 9: kmymoney-mymoneymoneytest
9/29 Test #9: kmymoney-mymoneymoneytest ................. Passed 0.54 sec
Start 10: kmymoney-mymoneyobjecttest
10/29 Test #10: kmymoney-mymoneyobjecttest ................ Passed 0.01 sec
Start 11: kmymoney-mymoneypayeetest
11/29 Test #11: kmymoney-mymoneypayeetest ................. Passed 0.01 sec
Start 12: kmymoney-mymoneytagtest
12/29 Test #12: kmymoney-mymoneytagtest ................... Passed 0.01 sec
Start 13: kmymoney-mymoneypricetest
13/29 Test #13: kmymoney-mymoneypricetest ................. Passed 0.01 sec
Start 14: kmymoney-mymoneyscheduletest
14/29 Test #14: kmymoney-mymoneyscheduletest .............. Passed 0.02 sec
Start 15: kmymoney-mymoneysecuritytest
15/29 Test #15: kmymoney-mymoneysecuritytest .............. Passed 0.01 sec
Start 16: kmymoney-mymoneysplittest
16/29 Test #16: kmymoney-mymoneysplittest ................. Passed 0.01 sec
Start 17: kmymoney-mymoneytransactiontest
17/29 Test #17: kmymoney-mymoneytransactiontest ...........***Failed 0.01 sec
Start 18: kmymoney-mymoneybudgettest
18/29 Test #18: kmymoney-mymoneybudgettest ................ Passed 0.01 sec
Start 19: kmymoney-mymoneybalancecachetest
19/29 Test #19: kmymoney-mymoneybalancecachetest .......... Passed 0.01 sec
Start 20: kmymoney-mymoneydatabasemgrtest
20/29 Test #20: kmymoney-mymoneydatabasemgrtest ........... Passed 125.74 sec
Start 21: kmymoney-mymoneymaptest
21/29 Test #21: kmymoney-mymoneymaptest ................... Passed 0.02 sec
Start 22: kmymoney-mymoneyseqaccessmgrtest
22/29 Test #22: kmymoney-mymoneyseqaccessmgrtest .......... Passed 0.02 sec
Start 23: kmymoney-plugin-csvdatetest
23/29 Test #23: kmymoney-plugin-csvdatetest ............... Passed 0.01 sec
Start 24: kmymoney-plugin-parsedatatest
24/29 Test #24: kmymoney-plugin-parsedatatest ............. Passed 0.02 sec
Start 25: kmymoney-plugin-symboltest
25/29 Test #25: kmymoney-plugin-symboltest ................ Passed 0.02 sec
Start 26: kmymoney-pivotgridtest
26/29 Test #26: kmymoney-pivotgridtest .................... Passed 0.01 sec
Start 27: kmymoney-pivottabletest
27/29 Test #27: kmymoney-pivottabletest ................... Passed 0.11 sec
Start 28: kmymoney-querytabletest
28/29 Test #28: kmymoney-querytabletest ................... Passed 0.07 sec
Start 29: kmymoney-convertertest
29/29 Test #29: kmymoney-convertertest .................... Passed 0.02 sec
97% tests passed, 1 tests failed out of 29
Total Test time (real) = 126.95 sec
The following tests FAILED:
17 - kmymoney-mymoneytransactiontest (Failed)
Errors while running CTest
make: *** [test] Error 8
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106846/#review21487
-----------------------------------------------------------
On Nov. 1, 2012, 11:07 p.m., Alessandro Russo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106846/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2012, 11:07 p.m.)
>
>
> Review request for KMymoney.
>
>
> Description
> -------
>
> 1) I created and almost completed the Tag tab in KMyMoneyView (KTagsView),
> it's similar to the payees tab.
> 2) I modified many classes in the storage folder and created a new class
> MyMoneyTag similar to MyMoneyPayee, now Tags save and load correctly but not
> all tag attribute (visibibleFrom,etc..) are saved/loaded yet.
> 3) I changed transactioneditor, transaction and KGlobalLedgerView, now there
> is a new widget called Tags in the translationeditor that someway works but
> no tags are shown in the ledger yet and no widget is showed when you insert
> or edit a transaction directly from the ledger (is this a feature that
> somebody uses?).
> 4) Missing features:
> - multi tags per transaction (only 1 tag can be added at this time)
> - no tag selection in reports
> - hierarchical tags (I'm rethinking about the real usefulness of this
> one... as implementing it will require some work )
> - in the tag tab you can select a color for the tag, this will be used to
> show the tag in the ledger with this color, also no visibility check is
> made.
> - no tags in a split
> Bugs:
> - in the tag tab if you select a tag and click on the 'New tag' button the
> selected tag wil be deleted and replaced with an empy "NewTag"
> - in the transaction editor when you edit a transaction with a tag the tag
> field is empty, when not in edit mode it show the tag name correctly.
> - many more...
>
>
> This addresses bug 207761.
> http://bugs.kde.org/show_bug.cgi?id=207761
>
>
> Diffs
> -----
>
> kmymoney/dialogs/CMakeLists.txt 9a8d782
> kmymoney/dialogs/kfindtransactiondlg.h 397d623
> kmymoney/dialogs/kfindtransactiondlg.cpp 506d752
> kmymoney/dialogs/kfindtransactiondlgdecl.ui d9e95ce
> kmymoney/dialogs/kreportconfigurationfilterdlg.cpp a50de29
> kmymoney/dialogs/ktagreassigndlg.h PRE-CREATION
> kmymoney/dialogs/ktagreassigndlg.cpp PRE-CREATION
> kmymoney/dialogs/ktagreassigndlgdecl.ui PRE-CREATION
> kmymoney/dialogs/transactioneditor.h 2535d96
> kmymoney/dialogs/transactioneditor.cpp 06c7fd1
> kmymoney/kmymoney.h 9482812
> kmymoney/kmymoney.cpp 1ef7400
> kmymoney/kmymoney.kcfg 95e33df
> kmymoney/kmymoneyui.rc 4294c46
> kmymoney/mymoney/CMakeLists.txt d2917b5
> kmymoney/mymoney/mymoneyfile.h 6c1aa25
> kmymoney/mymoney/mymoneyfile.cpp eef7126
> kmymoney/mymoney/mymoneyobjectcontainer.h 21cd74c
> kmymoney/mymoney/mymoneyobjectcontainer.cpp 2e9c496
> kmymoney/mymoney/mymoneyreport.h 7747353
> kmymoney/mymoney/mymoneyreport.cpp 24d75d8
> kmymoney/mymoney/mymoneysplit.h ded6b4c
> kmymoney/mymoney/mymoneysplit.cpp 168d1e6
> kmymoney/mymoney/mymoneysplittest.cpp f0d8851
> kmymoney/mymoney/mymoneytag.h PRE-CREATION
> kmymoney/mymoney/mymoneytag.cpp PRE-CREATION
> kmymoney/mymoney/mymoneytagtest.h PRE-CREATION
> kmymoney/mymoney/mymoneytagtest.cpp PRE-CREATION
> kmymoney/mymoney/mymoneytransactionfilter.h 2a7b85d
> kmymoney/mymoney/mymoneytransactionfilter.cpp 6650fef
> kmymoney/mymoney/mymoneytransactiontest.cpp f1a9687
> kmymoney/mymoney/storage/CMakeLists.txt 0495726
> kmymoney/mymoney/storage/imymoneyserialize.h ff49986
> kmymoney/mymoney/storage/imymoneystorage.h 8b980b7
> kmymoney/mymoney/storage/mymoneydatabasemgr.h ab587ed
> kmymoney/mymoney/storage/mymoneydatabasemgr.cpp f98a965
> kmymoney/mymoney/storage/mymoneydatabasemgrtest.h f2d05f2
> kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp d31bb02
> kmymoney/mymoney/storage/mymoneydbdef.h a2eecaf
> kmymoney/mymoney/storage/mymoneydbdef.cpp 9fa9781
> kmymoney/mymoney/storage/mymoneyseqaccessmgr.h da67e58
> kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp 232d6b2
> kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h c13d3da
> kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp 66354e4
> kmymoney/mymoney/storage/mymoneystorageanon.h 482fc9d
> kmymoney/mymoney/storage/mymoneystorageanon.cpp 0e7ebdd
> kmymoney/mymoney/storage/mymoneystoragebin.h af2b254
> kmymoney/mymoney/storage/mymoneystoragedump.cpp d36b4bb
> kmymoney/mymoney/storage/mymoneystoragesql.h 73875b3
> kmymoney/mymoney/storage/mymoneystoragesql.cpp 90ee818
> kmymoney/mymoney/storage/mymoneystoragexml.h 126cf8c
> kmymoney/mymoney/storage/mymoneystoragexml.cpp 88a02df
> kmymoney/reports/listtable.cpp d163f58
> kmymoney/reports/querytable.cpp 697f425
> kmymoney/views/CMakeLists.txt de0272f
> kmymoney/views/kgloballedgerview.cpp dfaecbd
> kmymoney/views/kmymoneyview.h 99ab398
> kmymoney/views/kmymoneyview.cpp 49dcc85
> kmymoney/views/kreportsview.cpp a868689
> kmymoney/views/ktagsview.h PRE-CREATION
> kmymoney/views/ktagsview.cpp PRE-CREATION
> kmymoney/views/ktagsviewdecl.ui PRE-CREATION
> kmymoney/widgets/kmymoney.widgets 857e42c
> kmymoney/widgets/kmymoneymvccombo.h 305e8a1
> kmymoney/widgets/kmymoneymvccombo.cpp 42a3687
> kmymoney/widgets/kmymoneyreportconfigtab3decl.ui ab150ee
> kmymoney/widgets/transaction.h a28053e
> kmymoney/widgets/transaction.cpp bfaafbf
>
> Diff: http://git.reviewboard.kde.org/r/106846/diff/
>
>
> Testing
> -------
>
> Wrote and run test cases. Several tests in xml and sql storage mode.
>
>
> Thanks,
>
> Alessandro Russo
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121106/846682da/attachment-0001.html>
More information about the KMyMoney-devel
mailing list