[Kmymoney-devel] [Bug 295162] The CSV Importer plugin crashes when changing the field delimiter

[allan]

https://bugs.kde.org/show_bug.cgi?id=295162


allan <agander93 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |agander93 at gmail.com




--- Comment #3 from allan <agander93 gmail com>  2012-03-01 22:21:10 ---
(In reply to comment #0)
> Created an attachment (id=69220)
 --> (http://bugs.kde.org/attachment.cgi?id=69220) [details]
> Testfile to reproduce the described bug
> 
> Version:           git master (using KDE 4.7.4) 
> OS:                Linux
> 
> The CSV Importer plugin crashes when changing between different values of the
> field delimiter.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Open the attached file
> 2. The field delimiter is set to semicolon(;)
> 3. Change it to comma(,)
> 4. Change it to semicolon(;)
> 
> 
> Actual Results:  
> Crash
> 
> Expected Results:  
> No crash

Yes, agreed.  Many apologies.  I concentrated so much on the new functionality
that I failed to check elsewhere properly.

The basic problem was that in CSVDialog::displayLine(), I had an if ()..else ()
structure, testing whether the memo field was to be copied to the payee field,
or vice-versa.  Or, that was the intent.  In fact, if the first test failed,
the code for the second case was executed without the second test actually
being present.  So, this second route was taken even if no copying was
required.

Secondly, changing the field delimiter affects the number of columns detected,
so changing this needs to reset the maximum column count, plus reset the
m_firstRead flag.  I think this was the cause of your second problem.

All looks well now, but I need to do more testing.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.