[Kmymoney-devel] Review Request: Bug 282949 - Extend date filter to more than 12 months

[Ian Neal]

> On Jan. 2, 2012, 11:14 a.m., Thomas Baumgart wrote:
> > kmymoney/mymoney/mymoneytransactionfilter.h, line 110
> > <http://git.reviewboard.kde.org/r/103443/diff/1/?file=43586#file43586line110>
> >
> >     You need to move this to the end of the list (there's a comment in the source where to add new values). Otherwise, you will break other peoples stored reports!

I've moved it so now reads:
     today,
+    next18Months,
     // insert new constants above of this line
     dateOptionCount

Just not sure how to generate the new diff to upload if needed.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103443/#review9441
-----------------------------------------------------------


On Dec. 18, 2011, 3:56 a.m., Ian Neal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103443/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 3:56 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Bug 282949 - Extend date filter to more than 12 months
> 
> 
> This addresses bug 282949.
>     http://bugs.kde.org/show_bug.cgi?id=282949
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneytransactionfilter.h 01bf81051a8e5a3078abf4e9a9684bbdf25679d8 
>   kmymoney/mymoney/mymoneytransactionfilter.cpp 0dbc6ee161ca0bb7fe30b17e9c9aede5a96aba7f 
>   kmymoney/widgets/kmymoneymvccombo.cpp 916882da9c5ba5bfac64fd51e4538f11f5f3ca34 
> 
> Diff: http://git.reviewboard.kde.org/r/103443/diff/diff
> 
> 
> Testing
> -------
> 
> Created some custom reports with 18 month period.
> Saved and reopened file.
> 
> 
> Thanks,
> 
> Ian Neal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120102/0461c12a/attachment.html>