[Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103492/
-----------------------------------------------------------

(Updated Feb. 20, 2012, 5:37 p.m.)


Review request for KMymoney.


Changes
-------

I'm keeping the 'Add new profile' combobox entry, but it's no longer essential to click it - a new name can be over-typed on that entry, or when the line-edit is empty, like after deleting a profile.  Over-typing any other entry will be treated as an attempt to edit that name.  It's no longer necessary to use the return key.

The UI has been made more responsive to start and end line changes.

A last minute change is the addition of a 'previous profile' setting, to pre-load the profile selection combo, so that the 'Add new profile' item does not appear automatically, except if there is no 'previous profile' entry.  So, a new user will see it in the line-edit at first, but subsequently it won't be selected automatically.

In general, a lot of tightening up has been done.  Many white space changes following earlier problems with my newer astyle revision.


Description
-------

The intro wizard is changed to have radio buttons to select either Banking or Investment.  Also, the selection combobox has an 'Add New Profile' item.  Once the user has named the profile, selected the file to be imported, selected the input parameters and completed the import, the new profile is saved.

Later, on selecting the appropriate profile and filename, the csv file is imported without needing to go through the wizard pages.

That's the theory, anyway, but unfortunately, it's not always as straight forward as that.  In general, though, banking files should be straight forward, but the 'last line' setting could cause a problem if there are trailer lines that need to be dropped.

With investment files, there appear to be two general formats involving the security.  The file could have a column for the ticker symbol, but often this may not be supplied on every line and the user will need to add this before import.  Or, if the file includes just one security with no symbol column, the security name needs to be input.  Also, it may be necessary to supply the name of a brokerage account.  So, with imports of investments, the import process is not so straight-forward.

Then, there is a potential problem if an error is detected during import.  The wizard then reverts to 'non-profile' mode, giving the user the chance to correct possible selection problems, like with the end line.

When a profile is used, on completion of the import process, the final wizard page has 'lost' its Back button (that is, it's disabled).  This, I'm pretty sure, is  because, with several pages being skipped, there is no 'history' available to the wizard.

An outstanding issue is that, should a profile be deleted, or renamed, the resource file will still contain its settings, and will need to be edited at some stage.

PS.
I probably should mention that when the plugin is installed, the default resource file gets installed in ${CONFIG_INSTALL_DIR}), then is saved locally.  The reason is that I've left settings in for two investment profiles, to give the user some clues.


Diffs (updated)
-----

  kmymoney/plugins/csvimport/CMakeLists.txt 9837a08 
  kmymoney/plugins/csvimport/completionwizardpage.ui 5adf2c2 
  kmymoney/plugins/csvimport/convdate.cpp 56bd235 
  kmymoney/plugins/csvimport/csvdatetest.cpp 7484d31 
  kmymoney/plugins/csvimport/csvdialog.h 6885072 
  kmymoney/plugins/csvimport/csvdialog.cpp 754ee92 
  kmymoney/plugins/csvimport/csvdialog.ui 282c7a9 
  kmymoney/plugins/csvimport/csvimporterplugin.h f525463 
  kmymoney/plugins/csvimport/csvimporterplugin.cpp 48fa8de 
  kmymoney/plugins/csvimport/csvimporterrc 3ba3f55 
  kmymoney/plugins/csvimport/csvutil.cpp b566b66 
  kmymoney/plugins/csvimport/introwizardpage.ui 2dee1ce 
  kmymoney/plugins/csvimport/investmentdlg.h a27fc0c 
  kmymoney/plugins/csvimport/investmentdlg.cpp 33ee8bd 
  kmymoney/plugins/csvimport/investmentwizardpage.ui c37f0d5 
  kmymoney/plugins/csvimport/investprocessing.h cf56056 
  kmymoney/plugins/csvimport/investprocessing.cpp 9c33531 
  kmymoney/plugins/csvimport/kmm_csvimport.desktop 68cbc6d 
  kmymoney/plugins/csvimport/lines-datewizardpage.ui 9a4bbb6 
  kmymoney/plugins/csvimport/parsedatatest.cpp fa8bdc0 
  kmymoney/plugins/csvimport/redefinedlg.h 8b11b28 
  kmymoney/plugins/csvimport/redefinedlg.cpp 44294ae 
  kmymoney/plugins/csvimport/redefinedlgdecl.ui 35d8f43 
  kmymoney/plugins/csvimport/separatorwizardpage.ui f9d07d3 
  kmymoney/plugins/csvimport/symboltabledlg.cpp b38a6c5 
  kmymoney/plugins/csvimport/symboltest.cpp ac70a95 

Diff: http://git.reviewboard.kde.org/r/103492/diff/


Testing
-------

Tested with several different file layouts, including live work.  astyle run, and unit test.


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120220/7117c05f/attachment.html>