[Kmymoney-devel] Review Request: Changing remaining transactions on scheduled transaction with a weekend option set can show an incorrect scheduled date

[Cristian Oneț]

> On Jan. 2, 2012, 11:08 a.m., Thomas Baumgart wrote:
> > kmymoney/dialogs/keditscheduledlg.cpp, line 478
> > <http://git.reviewboard.kde.org/r/103456/diff/1/?file=43834#file43834line478>
> >
> >     I expect this to break the logic!  Try what happens with the following data: start 30.12.2011, end 1.1.2011, change date to previous processing day. It should have 3 payments. Then save the entry and edit it again. Does it still have 3 payments? BTW: I expect the latest patch attached to https://bugs.kde.org/show_bug.cgi?id=290059 be installed.
> 
> Thomas Baumgart wrote:
>     Of course I mean 1.1.2012 to be the end date.

What is the status of this review request?


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103456/#review9438
-----------------------------------------------------------


On Dec. 18, 2011, 9:20 p.m., Ian Neal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103456/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 9:20 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Changing remaining transactions on scheduled transaction with a weekend option set can show an incorrect scheduled date
> 
> 
> This addresses bug 289306.
>     http://bugs.kde.org/show_bug.cgi?id=289306
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/keditscheduledlg.h 83fc913bc0a9590f6194520f27641fbad160be67 
>   kmymoney/dialogs/keditscheduledlg.cpp 7ddf3c3edd763992960cb86e52c5bb6d68efb9e6 
> 
> Diff: http://git.reviewboard.kde.org/r/103456/diff/
> 
> 
> Testing
> -------
> 
> Tested with patch, edit scheduled transaction dialog only shows processing dates when changing number of remaining transactions, best tested with a daily repeating transaction with 30 transactions.
> 
> 
> Thanks,
> 
> Ian Neal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120217/08db8ee0/attachment-0001.html>