[Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

Cristian Oneț onet.cristian at gmail.com
Fri Feb 17 21:13:12 UTC 2012 


> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote:
> > These are the runtime issues I've found so far:
> > 1. It's difficult to figure out that you have to press enter to create the new profile for the first time
> > 2. After I've created a profile I failed to create a second one
> > 3. When you go back to the initial page because of an error there is no 'Next' button and the user has to open a file even if one is opened already
> > 
> > That's all for now, I'll look deeper into why I could not save a second profile if you can't reproduce that.
> 
> Allan Anderson wrote:
>     1) I did show that in the tooltip.
>     2) I've managed to create several, on many occasions without that problem.
>     3) As explained in the Description, skipping pages in the wizard gave rise to some peculiar or unfortunate side effects, like the Finish button not appearing when the completion page had been skipped to. There was a similar problem in the return to the intro page and I used m_wizard->restart().  This restarts with the original button set-up, where advancing to the next page is via File Select.  I did consider not returning to the initial page, but to the following page, but I think I decided eventually to go back to the start to give the user the opportunity to select a different file, in case that was the cause of his error.  I will have another look, though.
>     
>     Thanks.
> 
> Cristian Oneț wrote:
>     2. This is caused by the hidden (to the user) functionality of the combobox, let me explain since I didn't figure this out until I was looking at the code:
>     
>     - It is important to actually select the 'Add new profile' entry from the combobox so that the new profile will actually be added, but then, why is 'Add new profile' selected by default? Once it's selected it's awkward that you have to keep in mind to reselect it again.
>     - If you select 'Add new profile' but you change your mind and want to select an existing profile you'll get the 'A profile named ' XXX ' already exists.' which I think is wrong
>     - the most important is that if you have not selected 'Add new profile' but just typed the name of the new profile since 'Add new profile' was already selected then you'll go trough the whole wizard thinking that you actually do something but loose the profile at the end because you did not select 'Add new profile' from the dropdown.
>
> 
> Allan Anderson wrote:
>     Just starting to look at this.
>     
>     > - If you select 'Add new profile' but you change your mind and want to select an existing profile you'll get the 'A profile named ' XXX ' already
>     > exists.' which I think is wrong
>     
>     How will I know that you've changed your mind?  What if you accidentally enter an existing profile , don't get a warning, and then carry on changing on the wrong profile?
>     
>     > - the most important is that if you have not selected 'Add new profile' but just typed the name of the new profile since 'Add new profile' was already 
>     > selected then you'll go trough the whole wizard thinking that you actually do something but loose the profile at the end because you did not select 
>     > 'Add new profile' from the dropdown.
>     
>     Unless I'm missing something, if you don't select 'Add new profile', but just over-type a new name, then when you hit return, that name is accepted, as long as it doesn't already exist, so you still get a new profile in the combo.
>
> 
> Cristian Oneț wrote:
>     > Unless I'm missing something, if you don't select 'Add new profile', but just over-type a new name, then when you hit return, that name is accepted, as long as it doesn't already exist, so you still get a new profile in the combo.
>     
>     You do get the new profile in the combo but in the end nothing will be saved and you loose all your configuration data.
> 
> Allan Anderson wrote:
>     That's true.  I didn't set out to enter new profiles that way, so it doesn't do the whole job.
>     
>     Would you prefer it to be accepted as a valid way of entering a new profile, or to be removed?  If it is included, it probably would avoid the need for
>     the 'Add new profile' entry, just initially display an empty edit box, or, still show the text, but clear it when text entry starts.
>

What is the status of this review request?


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103492/#review10101
-----------------------------------------------------------


On Jan. 15, 2012, 1:09 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103492/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2012, 1:09 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> The intro wizard is changed to have radio buttons to select either Banking or Investment.  Also, the selection combobox has an 'Add New Profile' item.  Once the user has named the profile, selected the file to be imported, selected the input parameters and completed the import, the new profile is saved.
> 
> Later, on selecting the appropriate profile and filename, the csv file is imported without needing to go through the wizard pages.
> 
> That's the theory, anyway, but unfortunately, it's not always as straight forward as that.  In general, though, banking files should be straight forward, but the 'last line' setting could cause a problem if there are trailer lines that need to be dropped.
> 
> With investment files, there appear to be two general formats involving the security.  The file could have a column for the ticker symbol, but often this may not be supplied on every line and the user will need to add this before import.  Or, if the file includes just one security with no symbol column, the security name needs to be input.  Also, it may be necessary to supply the name of a brokerage account.  So, with imports of investments, the import process is not so straight-forward.
> 
> Then, there is a potential problem if an error is detected during import.  The wizard then reverts to 'non-profile' mode, giving the user the chance to correct possible selection problems, like with the end line.
> 
> When a profile is used, on completion of the import process, the final wizard page has 'lost' its Back button (that is, it's disabled).  This, I'm pretty sure, is  because, with several pages being skipped, there is no 'history' available to the wizard.
> 
> An outstanding issue is that, should a profile be deleted, or renamed, the resource file will still contain its settings, and will need to be edited at some stage.
> 
> PS.
> I probably should mention that when the plugin is installed, the default resource file gets installed in ${CONFIG_INSTALL_DIR}), then is saved locally.  The reason is that I've left settings in for two investment profiles, to give the user some clues.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/CMakeLists.txt 9837a08 
>   kmymoney/plugins/csvimport/completionwizardpage.ui 5adf2c2 
>   kmymoney/plugins/csvimport/convdate.cpp 56bd235 
>   kmymoney/plugins/csvimport/csvdialog.h 6885072 
>   kmymoney/plugins/csvimport/csvdialog.cpp 754ee92 
>   kmymoney/plugins/csvimport/csvdialog.ui 282c7a9 
>   kmymoney/plugins/csvimport/csvimporterplugin.h f525463 
>   kmymoney/plugins/csvimport/csvimporterplugin.cpp 48fa8de 
>   kmymoney/plugins/csvimport/csvimporterrc 3ba3f55 
>   kmymoney/plugins/csvimport/csvutil.cpp b566b66 
>   kmymoney/plugins/csvimport/introwizardpage.ui 2dee1ce 
>   kmymoney/plugins/csvimport/investmentdlg.cpp 33ee8bd 
>   kmymoney/plugins/csvimport/investmentwizardpage.ui c37f0d5 
>   kmymoney/plugins/csvimport/investprocessing.h cf56056 
>   kmymoney/plugins/csvimport/investprocessing.cpp 9c33531 
>   kmymoney/plugins/csvimport/kmm_csvimport.desktop 55491d9 
>   kmymoney/plugins/csvimport/lines-datewizardpage.ui 9a4bbb6 
>   kmymoney/plugins/csvimport/parsedatatest.cpp fa8bdc0 
>   kmymoney/plugins/csvimport/redefinedlg.h 8b11b28 
>   kmymoney/plugins/csvimport/redefinedlg.cpp 44294ae 
>   kmymoney/plugins/csvimport/redefinedlgdecl.ui 35d8f43 
>   kmymoney/plugins/csvimport/separatorwizardpage.ui f9d07d3 
>   kmymoney/plugins/csvimport/symboltabledlg.cpp b38a6c5 
> 
> Diff: http://git.reviewboard.kde.org/r/103492/diff/
> 
> 
> Testing
> -------
> 
> Tested with several different file layouts, including live work.  astyle run, and unit test.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120217/ef0204fc/attachment.html>

More information about the KMyMoney-devel mailing list