[Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107507/#review24004
-----------------------------------------------------------

Ship it!


Looks good to me. Maybe at a later time, we can move this away from the OFX plugin to use it for other purposes as well.


kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp
<http://git.reviewboard.kde.org/r/107507/#comment18274>

    s/wither/either/


- Thomas Baumgart


On Nov. 29, 2012, 3:54 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107507/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 3:54 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> KWallet API is pretty cumbersome if we need to do this kind of hacking to make it's usage safe.
> I thought I'll put this one up for review to get your opinion about a fix like this.
> I would have preferred using a progress dialog as a permanent parent for the open operation but this was faster to write.
> 
> 
> This addresses bug 255764.
>     http://bugs.kde.org/show_bug.cgi?id=255764
> 
> 
> Diffs
> -----
> 
>   kmymoney/kmymoney.cpp fafceb0 
>   kmymoney/plugins/ofximport/dialogs/konlinebankingstatus.cpp faf7757 
>   kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.h 5538a5d 
>   kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp 4fc0c0d 
>   kmymoney/plugins/ofximport/ofximporterplugin.cpp 92dc76b 
> 
> Diff: http://git.reviewboard.kde.org/r/107507/diff/
> 
> 
> Testing
> -------
> 
> The main window can't be touched until the wallet dialog is dismissed one way or the other.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121226/6fefc6ff/attachment.html>